Conversation
|
🚀 Deployed on https://690d859a8529e72c9dcec430--opengeos.netlify.app |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dependency versions for MapLibre GL from using @latest to a pinned version @5.10.0 across all JavaScript and Python files to ensure more predictable and stable behavior.
- Replaces all
maplibre-gl@latestreferences withmaplibre-gl@5.10.0in JavaScript widgets and Python templates - Updates both JavaScript and CSS file URLs for MapLibre GL
- Applies the same versioning update to the geogrid-maplibre-gl package
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| anymap/static/maplibre_widget.js | Updates MapLibre GL JS/CSS URLs to version 5.10.0; also updates geogrid-maplibre-gl references |
| anymap/static/maplibre_compare_widget.js | Updates MapLibre GL JS/CSS URLs to version 5.10.0 in comparison widget |
| anymap/static/deckgl_widget.js | Updates MapLibre GL JS/CSS URLs to version 5.10.0 in DeckGL widget |
| anymap/deckgl.py | Updates MapLibre GL CDN URLs to version 5.10.0 in Python HTML template generation |
| anymap/compare.py | Updates MapLibre GL CDN URLs to version 5.10.0 in Python comparison template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try { | ||
| // Load GeoGrid as ES module via dynamic import | ||
| const geoGridModule = await import('https://unpkg.com/geogrid-maplibre-gl@latest'); | ||
| const geoGridModule = await import('https://unpkg.com/geogrid-maplibre-gl@5.10.0'); |
There was a problem hiding this comment.
The version 5.10.0 appears to be incorrect for the geogrid-maplibre-gl package. This version number (5.10.0) corresponds to maplibre-gl, not geogrid-maplibre-gl. The geogrid-maplibre-gl package has its own separate versioning scheme. This should either use @latest or a valid geogrid-maplibre-gl version number (e.g., @1.0.0 or similar, depending on the actual package versions available).
| const geogridCSS = document.createElement('link'); | ||
| geogridCSS.rel = 'stylesheet'; | ||
| geogridCSS.href = 'https://unpkg.com/geogrid-maplibre-gl@latest/dist/geogrid.css'; | ||
| geogridCSS.href = 'https://unpkg.com/geogrid-maplibre-gl@5.10.0/dist/geogrid.css'; |
There was a problem hiding this comment.
The version 5.10.0 appears to be incorrect for the geogrid-maplibre-gl package CSS file. This version number (5.10.0) corresponds to maplibre-gl, not geogrid-maplibre-gl. The geogrid-maplibre-gl package has its own separate versioning scheme. This should either use @latest or a valid geogrid-maplibre-gl version number that matches the JavaScript import on line 3338.
| geogridCSS.href = 'https://unpkg.com/geogrid-maplibre-gl@5.10.0/dist/geogrid.css'; | |
| geogridCSS.href = 'https://unpkg.com/geogrid-maplibre-gl@latest/dist/geogrid.css'; |
maplibre-js v5.11.0 has some issues with the geoman draw control. This PR pins maplibre-js to the working version v0.5.10.0