Conversation
|
🚀 Deployed on https://690e0e362ec572802b58e682--opengeos.netlify.app |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables snapping by default in the Geoman draw control and updates the documentation to reflect this change. Snapping helps users create precise geometries by snapping to existing features when drawing on the map.
- Enables snapping by default in the
add_geoman_controlmethod - Updates the Jupyter notebook example to document the default snapping behavior and show how to disable it
- Removes commented-out configuration example and replaces it with a clearer custom configuration section
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
anymap/maplibre.py |
Adds logic to enable snapping by default in the Geoman control configuration |
docs/examples/maplibre_geoman.ipynb |
Documents the new snapping default behavior and provides an example of how to disable it |
Comments suppressed due to low confidence (1)
anymap/maplibre.py:1752
- The snapping default is set before user-provided
controlsare processed, but thecontrolsparameter uses.update()which can override nested values. If a user passescontrols={\"helper\": {\"snapping\": {}}}, the empty dict will override the default{\"active\": True}, resulting in snapping being disabled when it should be enabled by default. Consider checking for theactivekey after merging user controls, or use a deep merge strategy that preserves the default when not explicitly overridden.
# Enable snapping by default
geoman_controls = geoman_config.setdefault("controls", {})
helper_controls = geoman_controls.setdefault("helper", {})
snapping_config = helper_controls.setdefault("snapping", {})
if "active" not in snapping_config:
snapping_config["active"] = True
if controls:
for section, section_options in controls.items():
if isinstance(section_options, dict):
section_config = geoman_controls.setdefault(section, {})
section_config.update(section_options)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.