Skip to content

Update map class name#139

Merged
giswqs merged 2 commits intomainfrom
Map
Nov 23, 2025
Merged

Update map class name#139
giswqs merged 2 commits intomainfrom
Map

Conversation

@giswqs
Copy link
Copy Markdown
Member

@giswqs giswqs commented Nov 23, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 23, 2025 01:22
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 23, 2025

@github-actions github-actions Bot temporarily deployed to pull request November 23, 2025 01:24 Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates all MapLibre map instantiations in example notebooks to use the simpler anymap.Map class name instead of anymap.MapLibreMap. The Map class is an alias for MapLibreMap defined in the package's __init__.py, making it the recommended default map class for users.

  • Simplified class name from anymap.MapLibreMap to anymap.Map across all examples
  • Updated notebook metadata (Python version and kernel display name) in authorization_headers_example.ipynb

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/examples/maplibre/to_html.ipynb Updated two map instantiations to use anymap.Map instead of anymap.MapLibreMap
docs/examples/maplibre/authorization_headers_example.ipynb Updated six map instantiations to use anymap.Map, commented out request_headers parameter in first example, and updated notebook metadata (Python version to 3.12.9 and kernel name to "geo")
docs/examples/maplibre/add_vector_editor_example.ipynb Updated five map instantiations to use anymap.Map instead of anymap.MapLibreMap

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

" center=[-74.0060, 40.7128],\n",
" zoom=12,\n",
" request_headers={\"Authorization\": \"Bearer YOUR_TOKEN_HERE\"},\n",
" # request_headers={\"Authorization\": \"Bearer YOUR_TOKEN_HERE\"},\n",
Copy link

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request_headers parameter has been commented out. This appears to be the first example demonstrating how to set authorization headers at map creation, but the key functionality is now commented out.

If this is intentional for the example to run without requiring a token, consider either:

  1. Keeping the parameter uncommented but adding a note in the markdown explaining it's optional
  2. Moving this to a different example and starting with Example 2 (setting headers after creation) as the first example

Copilot uses AI. Check for mistakes.
@giswqs giswqs merged commit 3055973 into main Nov 23, 2025
7 checks passed
@giswqs giswqs deleted the Map branch November 23, 2025 01:27
@github-actions github-actions Bot temporarily deployed to pull request November 23, 2025 01:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants