Merged
Conversation
|
🚀 Deployed on https://692281c2d7387f847b10e1a3--opengeos.netlify.app |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for marker groups in MapLibre, addressing issue #123. Marker groups allow multiple markers to be grouped together as a single controllable layer with unified visibility and opacity controls through the layer control panel.
- Adds
add_marker_group()method to create groups of markers as controllable layers - Extends
set_visibility(),set_opacity(), andremove_layer()to handle marker groups - Integrates marker groups with the layer control UI for seamless management
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/examples/maplibre/marker_groups_example.ipynb | Comprehensive Jupyter notebook demonstrating marker group functionality with multiple examples including basic usage, visibility/opacity control, multiple groups, customization, and integration with other layer types |
| anymap/static/maplibre_widget.js | JavaScript implementation for marker group rendering, visibility/opacity controls, layer control integration, and cleanup logic |
| anymap/maplibre.py | Python API implementation including add_marker_group() method and marker group-specific handling in set_visibility(), set_opacity(), and remove_layer() methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #123