Skip to content

Fix info box bug#153

Merged
giswqs merged 1 commit intomainfrom
info
Nov 24, 2025
Merged

Fix info box bug#153
giswqs merged 1 commit intomainfrom
info

Conversation

@giswqs
Copy link
Copy Markdown
Member

@giswqs giswqs commented Nov 24, 2025

Only activate the delete button once.

Copilot AI review requested due to automatic review settings November 24, 2025 20:41
@giswqs giswqs merged commit 18c0909 into main Nov 24, 2025
11 checks passed
@giswqs giswqs deleted the info branch November 24, 2025 20:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where a workaround for initializing info box handlers could run multiple times, potentially causing accidental deletion of selected features. The fix introduces a session-level flag to ensure the workaround executes only once.

  • Added _workaroundCompleted flag to track whether the delete button workaround has been executed
  • Modified the workaround condition to check both the in-progress flag and the completion flag
  • Set the completion flag in all exit paths of the workaround code (success, failure, and error cases)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request November 24, 2025 20:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants