Restrict Domain and NdArray dimensionality to >= 1#71
Merged
chris-little merged 2 commits intomasterfrom May 11, 2022
Merged
Conversation
Contributor
Author
|
@letmaik does this look OK? |
letmaik
reviewed
May 4, 2022
Contributor
letmaik
left a comment
letmaik
left a comment
There was a problem hiding this comment.
Looks good, just one minor addition.
chris-little
approved these changes
May 4, 2022
Contributor
chris-little
left a comment
chris-little
left a comment
There was a problem hiding this comment.
@letmaik @jonblower Looks good to me. We can always loosen back to 0D if a convincing use case emerges.
Contributor
|
Agreed at 2022-05-11 meeting to merge and close issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #68