fix issue on value relations for enumerations with geopackage #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@signedav , is this ready for review? |
Member
Author
|
Yes. I'll fix the tests... |
gacarrillor
reviewed
May 27, 2025
Member
gacarrillor
left a comment
gacarrillor
left a comment
There was a problem hiding this comment.
I'd rather attempt to use the member variables from DBConnector to get those names from the provider.
Not sure what's the best way to do so, though. If you find that passing the whole DB connector is too much (and I'd agree), perhaps we could have a single member dict variable my_db_connector.db_names or sth like that, that we could pass to other classes that need to have access to those names.
But this is just an idea, I hope we can find a good way to code it.
modelbaker/dataobjects/project.py
Outdated
| "OrderByFieldName": "seq", | ||
| }, | ||
| ) | ||
| print(editor_widget_setup) |
…the t_id is written differently)
Member
|
@signedav , any comments on the review :) ? |
Member
Author
Oh have overseen that. Sorry. I will check it out next week and probably do a follow up. |
signedav
added a commit
that referenced
this pull request
Jun 12, 2025
…he layer and use it in the generation of the project. This concerns #138 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(since the t_id is written differently)