Skip to content

Add method to suppress any catalogue reference layer that doesn't have a BAG OF attribute #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

Add method to suppress any catalogue reference layer that doesn't have a BAG OF attribute #140

merged 3 commits into from
Jun 6, 2025

Conversation

@gacarrillor
Copy link
Member

@gacarrillor gacarrillor commented Jun 2, 2025

(when using coalesceCatalogueRef)

@gacarrillor gacarrillor mentioned this pull request Jun 2, 2025
Merged
@gacarrillor gacarrillor force-pushed the supress_catalogue_ref_if_not_bag_of branch from 147400b to bf45678 Compare June 2, 2025 16:52
@gacarrillor
Add method to supress any catalogue reference layer that doesn't have…
60a88a2 
… a BAG OF attribute (when using coalesceCatalogueRef)
@gacarrillor gacarrillor force-pushed the supress_catalogue_ref_if_not_bag_of branch from bf45678 to 60a88a2 Compare June 2, 2025 17:07
@gacarrillor gacarrillor requested a review from signedav June 2, 2025 17:30
@gacarrillor
Copy link
Member Author

gacarrillor commented Jun 2, 2025

@signedav, we still lack unit tests on this one, but I think I'll tackle the 3rd task (validator verbosity) before.

@gacarrillor gacarrillor changed the title Add method to supress any catalogue reference layer that doesn't have a BAG OF attribute Add method to suppress any catalogue reference layer that doesn't have a BAG OF attribute Jun 4, 2025
@gacarrillor
[tests] Suppress catalogue ref (when not bag of): Add unit tests for …
afd1501 
…GPKG and PG (MSSQL db connector does not find bag_ofs yet)
@gacarrillor
Copy link
Member Author

gacarrillor commented Jun 4, 2025

@signedav, we still lack unit tests on this one, but I think I'll tackle the 3rd task (validator verbosity) before.

Unit tests added ✅

signedav
signedav approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@signedav signedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Did it concerns LIST ... OF same as bag of? If not, this should be added, I guess...

@signedav
Copy link
Member

signedav commented Jun 6, 2025

If LIST OF is added, feel free to make another release of the Library (minor version), then bump it in QgisModelBaker to test and merge the PRs there @gacarrillor

@gacarrillor
[tests] Don't suppress catalogue ref (when LIST OF): Add unit tests f…
491f866 
…or GPKG and PG (MSSQL db connector does not find list_ofs yet)
@gacarrillor
Copy link
Member Author

gacarrillor commented Jun 6, 2025

Tests added for LISTs OF. It turned out that that case was already handled by this PR (I didn't know about that 😄).

@gacarrillor gacarrillor merged commit 9dd6436 into main Jun 6, 2025
5 checks passed
@gacarrillor gacarrillor deleted the supress_catalogue_ref_if_not_bag_of branch June 6, 2025 16:00
@gacarrillor
Copy link
Member Author

gacarrillor commented Jun 6, 2025

If LIST OF is added, feel free to make another release of the Library (minor version), then bump it in QgisModelBaker to test and merge the PRs there @gacarrillor

This is done! ✅

@signedav signedav mentioned this pull request Oct 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@signedav signedav signedav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gacarrillor @signedav