Skip to content

Remove alias syntax to support macOS build#75

Merged
esproul merged 1 commit intoopenhistogram:masterfrom
tidefield:master
Sep 4, 2025
Merged

Remove alias syntax to support macOS build#75
esproul merged 1 commit intoopenhistogram:masterfrom
tidefield:master

Conversation

@tidefield
Copy link
Copy Markdown
Contributor

When building for macOS as part of envoyproxy/envoy#40967, the compiler yields an error

external/com_github_openhistogram_libcircllhist/src/circllhist.c:685:25: error: aliases are not supported on darwin
685 | uint64_t attribute((alias("hist_approx_count_below_inclusive"))) hist_approx_count_below(const histogram_t *hist, double threshold);
| ^
external/com_github_openhistogram_libcircllhist/src/circllhist.c:686:25: error: aliases are not supported on darwin
686 | uint64_t attribute((alias("hist_approx_count_above_inclusive"))) hist_approx_count_above(const histogram_t *hist, double threshold);

This PR simply replaces the alias syntax with the same implementation.

@bdunavant bdunavant requested a review from esproul September 4, 2025 09:29
Copy link
Copy Markdown
Member

@esproul esproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@esproul esproul merged commit 3f40320 into openhistogram:master Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants