feat(ux): add keyboard shortcuts cheat sheet#17
Merged
Conversation
- add centralized keyboard shortcuts configuration (src/constants/shortcuts.ts) - create KeyboardShortcutsModal component with grouped shortcuts display - add shortcuts button (keyboard icon) to Header - update execute and cancel button titles with shortcut hints (ctrl+enter, esc) - wire global ctrl+/ handler in App.tsx to toggle shortcuts modal - add i18n translations for shortcuts in en.json and fr.json - add unit tests for KeyboardShortcutsModal
openhoat
force-pushed
the
feat/ux-shortcuts
branch
from
66db543 to
f31bd2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/constants/shortcuts.ts)KeyboardShortcutsModalcomponent with grouped shortcut display andkbdbadgesCtrl+/(and?) handler inApp.tsxto toggle shortcuts modalen.jsonandfr.jsonKeyboardShortcutsModalTest plan
Ctrl+/— shortcuts modal should appear?outside a text input — shortcuts modal should appearEscapein the modal — modal should closenpm run validate— all checks pass