Improve private notes voice flows#256
Open
Ju-usc wants to merge 3 commits intoopenhome-dev:devfrom
Open
Conversation
Contributor
🔀 Branch Merge CheckPR direction: ✅ Passed — |
Contributor
✅ Community PR Path Check — PassedAll changed files are inside the |
Contributor
✅ Ability Validation Passed |
Contributor
🔍 Lint ResultsFiles linted: ✅ Flake8 — Passed
|
19 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the Private Notes voice flow by adding topic search, reducing prompt exposure of note bodies by default, and centralizing destructive-action confirmations in Python for consistent safety behavior.
Changes:
- Added
search_notestool and updated the voice loop contract to support topic/keyword queries. - Adjusted tool loop parsing/handling to be more resilient and to prevent confirmations via
ask_followup. - Hardened persistence behavior by validating stored notebook shape and refusing to operate on malformed storage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| community/private-notes/SPEC.md | Updates spec to add search, Python-owned confirmations, and malformed-storage safety rules. |
| community/private-notes/README.md | Documents new search behavior and voice UX expectations around confirmations/titles. |
| community/private-notes/main.py | Implements search_notes, confirmation-question generation, stricter notebook validation, and improved tool-call parsing/loop behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ba91772 to
2ad9392
Compare
2ad9392 to
6f14726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3 validate_ability.py community/private-notespython3 -m py_compile community/private-notes/main.py