This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Removed custom String#starts_with? and #ends_with?#62
Merged
dennisreimann merged 3 commits intoopenid:masterfrom Jan 7, 2015
tobiashm:master
Merged
Removed custom String#starts_with? and #ends_with?#62dennisreimann merged 3 commits intoopenid:masterfrom tobiashm:master
dennisreimann merged 3 commits intoopenid:masterfrom
tobiashm:master
Conversation
added 2 commits
October 15, 2013 16:40
…port is deprecated. The methods were introduced with Ruby 1.8.7 and 1.9.0, and since the library is now only targeted 1.9.2+ there is no need for this extra code.
Contributor
|
Hello Tobias, can you make this work with the current version? I'll merge this once Travis gives thumbs up :) |
Contributor
Author
|
Looks like a problem with JRuby returning I will report to JRuby. |
Conflicts: test/test_extras.rb
Contributor
Author
|
The issue with |
dennisreimann
added a commit
that referenced
this pull request
Jan 7, 2015
Removed custom String#starts_with? and #ends_with?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Ruby 1.8.7 and newer defines String#start_with? and #end_with?, and Ruby 1.8 support has been deprecated for this library, we can just use the build in methods and remove the extra code.