This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Allow expecting a parameter to be nil during return_to verification.#70
Merged
dennisreimann merged 1 commit intoopenid:masterfrom Jan 27, 2014
pierre-pretorius:master
Merged
Allow expecting a parameter to be nil during return_to verification.#70dennisreimann merged 1 commit intoopenid:masterfrom pierre-pretorius:master
dennisreimann merged 1 commit intoopenid:masterfrom
pierre-pretorius:master
Conversation
dennisreimann
added a commit
that referenced
this pull request
Jan 27, 2014
Allow expecting a parameter to be nil during return_to verification.
Contributor
|
Thanks for your contribution - I just pulled in those changes and pushed v2.4.0 to rubygems :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a minor openid change on Google's side that caused all our applications using the ruby-openid gem to fail when authorizing users via Google openid. After some debugging I determined the return_to parameter in the response from Google changed from:
to:
This causes the verify_return_to_args method to reject the response even though the rt_key (expected result) is nil.
Please accept my pull request that addresses this problem. It doesn't reject the response if the rt_key (expected result) is also nil.