Conversation
meddhiakassab
added
documentation
zikani03
left a comment
zikani03
left a comment
There was a problem hiding this comment.
Looks okay. Though, I don't know what we can do about the example issue numbers since they may trigger Github to link to actual issues/prs if those numbers exist.
Maybe consider #NNN ?
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| A clear, concise description of the change. Why is it needed? What problem does it solve? | ||
|
|
||
| Motivation ? |
There was a problem hiding this comment.
Consider remove, as the questions above already cover this.
There was a problem hiding this comment.
Adding this to the top will be a nice message for contributor:
#Thank you for your contribution to openIMIS!
#Please complete the sections below. Anything in comments is guidance and can be deleted.
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| A clear, concise description of the change. Why is it needed? What problem does it solve? | ||
|
|
||
| Motivation ? |
There was a problem hiding this comment.
Adding this to the top will be a nice message for contributor:
#Thank you for your contribution to openIMIS!
#Please complete the sections below. Anything in comments is guidance and can be deleted.
delcroip
left a comment
delcroip
left a comment
There was a problem hiding this comment.
Overall there is good intentions but I think it is important to focus on area that are critical, please remember that only few org are creating PR outside contractual link with GIZ/WB (SwissTPH, YNote) making the process too annoying will simply lead to no one creating PR outside contract obligations
|
@ajinkyagadewar we agreed during the call to try to keep the template lean and not overburden contributors when opening PRs. Maybe those other fields can be written as a recommendation elsewhere instead of this template to avoid bloating it? |
weilu
left a comment
weilu
left a comment
There was a problem hiding this comment.
@meddhiakassab there are still two comments that remain unaddressed.
zikani03
left a comment
zikani03
left a comment
There was a problem hiding this comment.
@meddhiakassab please address the remaining comments from Wei
meddhiakassab
requested review from
ajinkyagadewar,
delcroip,
weilu and
zikani03
chore: removing motivation as already covered by questions above
5 participants
Description
Adds a global pull request template to standardize PR descriptions, types, related issues, demos, and checklists across the team.
Requested changes from @weilu have been added (openimis/openimis-be_py#363) , Pull requests that were previously created for adding individual templates have been closed, as they are no longer ready for review.
The issue form is disabled; the Issues tab in repositories will no longer be used, as OpenIMIS developers and reporters are using Atlassian products for issue tracking.
Demo showing the closing of batches of legacy OpenIMIS documentation pull requests
demo-close-batch-doc-openimis-prs.mp4