Added build variants for Claims App #24
Conversation
claimManagement/build.gradle
Outdated
| } | ||
| productFlavors { | ||
| demoProd { | ||
| buildConfigField "String", "API_BASE_URL", '"http://demo.openimis.org/rest/"' |
There was a problem hiding this comment.
Change applicationId as org.openimis.imisclaims.demoProd. Do this change for other flavors so we can install all versions on same phone.
There was a problem hiding this comment.
I added this. You can install all builds on a single device, but it's hard to determine which is which (nearly all the builds use the same name and icon).
There was a problem hiding this comment.
Please look on Policies mobile app gradle: https://github.com/openimis/policies_android_app_java/blob/master/app/build.gradle#L51
We are changing the app name based on the build variant. Can you please make this change also?
There was a problem hiding this comment.
I updated the build variants app names to "Claims (VARIANT)"
CaptureActivity/build.gradle
Outdated
| } | ||
| productFlavors { | ||
| demoProd { | ||
| buildConfigField "String", "API_BASE_URL", '"http://demo.openimis.org/rest/"' |
There was a problem hiding this comment.
Do we need API_BASE_URL in this library?
There was a problem hiding this comment.
I deleted unused build config fields.
claimManagement/build.gradle
Outdated
| } | ||
|
|
||
| sourceSets { | ||
| chfDev.res.srcDir 'src/chf/res' |
There was a problem hiding this comment.
Do we have escape procedures for ValidateCHF? Do we need to have specific java.srcDir here?
There was a problem hiding this comment.
I added source sets with Escape.java for every build variant.
|
|
||
| //Post with Token | ||
| public HttpResponse postToRestApiToken(final JSONObject object, final String functionName) { | ||
| setProperUri(functionName); |
There was a problem hiding this comment.
You removed this function call. Is this to manage the 2 REST APIs? Should this be removed only after REST APIs integration?
There was a problem hiding this comment.
I fixed the setProperUri function.
|
@dborowiecki will you finish this issue or @malinowskikam will do? |
|
@malinowskikam Can you take a look at this? Tell me if anything about issue is unclear. |
| package org.openimis.imisclaims; | ||
|
|
||
| public class Escape { | ||
| public boolean CheckCHFID(String InsureeNumber) { |
There was a problem hiding this comment.
CHF is using modulo 7 validation. Please add same validation as in Policies: https://github.com/openimis/policies_android_app_java/blob/develop/app/src/chf/java/org/openimis/imispolicies/Escape.java
There was a problem hiding this comment.
I added the CHFID validation from Policies app to chfDev build
|
Please take the Policies mobile app as reference for this work: https://github.com/openimis/policies_android_app_java/blob/master/app/build.gradle |
|
@dragos-dobre i fixed all the issues, can you re-review? |
Added build variants.
Changes: