OTC-64: RfC 112 Acquring of claims #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option to fill ClaimActivity with retrived claim, Added date conversion to ClaimAdapter, Added option to restore claim in ClaimReview, Added insurance number to ReviewFragment, Added otion to retrive disease code with name.
Contributor
Author
|
@dragos-dobre Can you review? |
dragos-dobre
requested changes
Mar 10, 2021
claimManagement/src/main/java/org/openimis/imisclaims/SQLHandler.java
Outdated
Show resolved
Hide resolved
dragos-dobre
requested changes
Mar 11, 2021
| private void fillForm(JSONObject obj) | ||
| { | ||
| try { | ||
| String newClaimNumber = "@" + obj.getString("claim_number"); |
Member
There was a problem hiding this comment.
The '@' prefix is configured in Web.config in WebApp. We should be able to change easily this prefix. Nepal put 're' as prefix. Please add this in strings.xml and take the value from there.
Contributor
Author
There was a problem hiding this comment.
I replaced it with a resource, so now i can be easily changed.
malinowskikam
force-pushed
the
feature/OTC-64
branch
from
a059843 to
2ebf31a
Compare
dragos-dobre
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
-Added option to fill ClaimsActivity with JSON data (for restoring claims)
-Changed how claim restore works (to fit the rfc)
-Added functionality to get disease code with name
-Changed some layouts to fit new funcionality
-Added changes from build variants for compability