Skip to content

Conversation

@sniedzielski
Copy link
Contributor

@sniedzielski sniedzielski commented May 6, 2021

TICKET: https://openimis.atlassian.net/browse/OTC-254

Please get to know with the changes. I created them during fixing bug on init start app on Android <=10. Error was due to too quick processing file/folders before granting perms onCreate in MainActivity.

changes:

  • processing files/folders path etc in "onRequestPermission" when the perms are granted
  • moving 'refreshCount' to the "onRequestPermission" when the perms are granted
  • check if db file exists - if exists - then only ask for admin code without init db again. If db doesn't exist then init db/create tables and fill data.
  • remove processing claims from "trash" folder when we click "Upload claims" in "Synchronize" (discussed with @delcroip on Thursday)
  • move to the "Trash" folder also JSON files when we click "Create XML" in "Synchronize" (discussed with @delcroip on Thursday)
  • count "pending" folders only from pending claims, not pending+trash

also includes one of the change dedicated for this ticket https://openimis.atlassian.net/browse/OTC-255

  • this change is about processing db path into proper folder.

I tested my changes on MV:

  • emulators with android 10/11
  • real devices:
    a) Lenovo with Android 7
    b) Samsung Galaxy with Android 11

@sniedzielski sniedzielski changed the title OFS:254 Android 10/11 Compatibility in Claims app - part 2 OFS-254: Android 10/11 Compatibility in Claims app - part 2 May 6, 2021
@sniedzielski sniedzielski marked this pull request as ready for review May 7, 2021 08:28
@sniedzielski sniedzielski changed the title OFS-254: Android 10/11 Compatibility in Claims app - part 2 OTC-254: Android 10/11 Compatibility in Claims app - part 2 May 12, 2021
@dragos-dobre dragos-dobre merged commit 11090cd into develop May 27, 2021
@dragos-dobre dragos-dobre deleted the feature/OTC-254 branch May 27, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants