OP-324: Delete member of family in uspConsumeEnrollment#66
Merged
Conversation
sniedzielski
changed the title
delcroip
requested changes
Apr 21, 2021
| SELECT CHFID FROM @tblInsuree TI | ||
| ) tbl | ||
| GROUP BY CHFID | ||
| HAVING count(*) = 1 |
Member
There was a problem hiding this comment.
This will get also the new insuree
Why not doing a left join
SELECT CHFID FROM @insureeToProcess IP
LEFT JOIN @tblInsuree I ON I.CHFID=IP.CHFID
WHERE I.CHFID is NULL
Contributor
Author
There was a problem hiding this comment.
Ok @delcroip . I will try to do this and check if it works.
Thx for clue.
Contributor
Author
|
@delcroip You can re-check this PR. I added approach with LEFT JOIN |
delcroip
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: https://openimis.atlassian.net/browse/OP-324
In that PR I want to add missing part (deleting insuree from family based on received XML payload) in uspConsumeEnrollment. When we have no insuree in payload - then we can delete this one using SP 'uspAPIDeleteMemberFamily' and updateTblInsureePolicy with setting validityTo.
Earlier such case wasn't implemented and that is why this TestCase doesn't pass scenario after synch in policy mobile app.