Niger and a bit more #117
Merged
Niger and a bit more #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niger will have different apps depending on the district where they'll be deployed. The manual build was all manual or niger, not a mix.
The error logging was consuming the response body and crashed the app in some conditions, like a failed login.
dragos-dobre
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve manual build, add gradle cache, add android cache (this has the huge benefit of keeping the debug keystore so that you can upgrade the apks generated by the actions.
Also improved error logging in the app itself so that error don't get completely swallowed. An improvement would be to report those to the UI with a "debug" parameter or something similar.