Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java #10099

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 31, 2022

After JDK-8242181, runtime/ErrorHandling/TestDwarf.java fails in GHA:

...
[dwarf] ##### Find filename and line number for offset 0x00085ff1 in library /lib32/libc.so.6 #####
[dwarf] Failed to load DWARF file for library /lib32/libc.so.6 or find DWARF sections directly inside it.
#
# Compiler replay data is saved as:
# /home/runner/work/jdk/jdk/build/run-test-prebuilt/test-support/jtreg_test_hotspot_jtreg_tier1_runtime/scratch/replay_pid5024.log
#
# If you would like to submit a bug report, please visit:
# https://bugreport.java.com/bugreport/crash.jsp
#

hs_err_file: hs_err_pid5024.log
----------System.err:(16/999)----------
java.lang.RuntimeException: Must find library in "C [libc.so.6+0x85ff1]": expected true, was false
at jdk.test.lib.Asserts.fail(Asserts.java:594)
at jdk.test.lib.Asserts.assertTrue(Asserts.java:486)
at TestDwarf.checkNoSourceLine(TestDwarf.java:181)
at TestDwarf.runAndCheck(TestDwarf.java:153)
at TestDwarf.test(TestDwarf.java:101)
at TestDwarf.main(TestDwarf.java:91)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
at java.base/java.lang.Thread.run(Thread.java:1589)

We might want to consider making this test more resilient for these cases, but it seems beneficial to let current GHA hosts run it too, by providing the packages carrying the missing .so file.

Additional testing:

  • x86_32 GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10099/head:pull/10099
$ git checkout pull/10099

Update a local copy of the PR:
$ git checkout pull/10099
$ git pull https://git.openjdk.org/jdk pull/10099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10099

View PR using the GUI difftool:
$ git pr show -t 10099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10099.diff

@shipilev shipilev changed the title 8293165: GHA config: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java 8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java Aug 31, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 31, 2022
@shipilev shipilev marked this pull request as ready for review August 31, 2022 12:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 31, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2022

Webrevs

@magicus magicus mentioned this pull request Aug 31, 2022
4 tasks
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 0d51f63: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation
  • 5d6779f: 8292681: Add JMH for ProtectionDomain
  • 38e6706: 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler
  • 4c90e87: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 9e3176b: 8293035: Cleanup MacroAssembler::movoop code patching logic aarch64 riscv
  • c42478b: 8293109: Remove unused methods in Compiler

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 31, 2022
@shipilev
Copy link
Member Author

Thanks, I am going to integrate to make GHAs clean again.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

Going to push as commit 372fc58.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 3c1bda4: 8293019: [JVMCI] change ratio of libgraal to C1 threads and use one isolate per libgraal thread
  • 0d51f63: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation
  • 5d6779f: 8292681: Add JMH for ProtectionDomain
  • 38e6706: 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler
  • 4c90e87: 8290781: Segfault at PhaseIdealLoop::clone_loop_handle_data_uses
  • 9e3176b: 8293035: Cleanup MacroAssembler::movoop code patching logic aarch64 riscv
  • c42478b: 8293109: Remove unused methods in Compiler

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2022
@openjdk openjdk bot closed this Aug 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2022
@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@shipilev Pushed as commit 372fc58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8293165-gha-dwarf branch September 5, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants