JDK-8293003: Review running time of Warn5 regression test

[jddarcy]

Refactoring of the Warn5 regression test to reduce its running time by more than 50%.

Included a small refactoring in Warn4 to use text blocks too.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293003: Review running time of Warn5 regression test

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10130/head:pull/10130
$ git checkout pull/10130

Update a local copy of the PR:
$ git checkout pull/10130
$ git pull https://git.openjdk.org/jdk pull/10130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10130

View PR using the GUI difftool:
$ git pr show -t 10130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10130.diff

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1dfd2bd6)

[vicente-romero-oracle]

looks sensible

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293003: Review running time of Warn5 regression test

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 99c3ab0: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
• 0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
• 0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
• 032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• e393973: 8292990: Improve test coverage for XPath Axes: parent
• fa68371: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
• 04d8069: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
• 3d254d3: 8289510: Improve test coverage for XPath Axes: namespace

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

/integrate

[openjdk]

Going to push as commit 3ac91b0.
Since your change was applied there have been 9 commits pushed to the master branch:

• e0168a0: 8288012: AArch64: unnecessary macro expansion in stubGenerator_aarch64
• 99c3ab0: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
• 0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
• 0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
• 032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
• e393973: 8292990: Improve test coverage for XPath Axes: parent
• fa68371: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
• 04d8069: 8230374: maxOutputSize, instead of javatest.maxOutputSize, should be used in TEST.properties
• 3d254d3: 8289510: Improve test coverage for XPath Axes: namespace

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit 3ac91b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.