8294361: Cleanup usages of StringBuffer in SQLOutputImpl #10320

turbanoff · 2022-09-17T21:43:04Z

There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
All of them create StringBuffer from single character and then concatenate with String. Instead of this, we can concatenate character directly.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8294361: Cleanup usages of StringBuffer in SQLOutputImpl

Reviewers

Roger Riggs (@RogerRiggs - Reviewer)
Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10320/head:pull/10320
$ git checkout pull/10320

Update a local copy of the PR:
$ git checkout pull/10320
$ git pull https://git.openjdk.org/jdk pull/10320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10320

View PR using the GUI difftool:
$ git pr show -t 10320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10320.diff

bridgekeeper · 2022-09-17T21:43:51Z

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-17T21:46:23Z

@turbanoff The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-26T10:20:11Z

Webrevs

00: Full (3f656325)

RogerRiggs · 2022-09-26T14:53:24Z

src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java

+        BufferedReader bufReader = new BufferedReader(x);
+        try {
+            int i;
+            while ((i = bufReader.read()) != -1) {


Is the single character read really necessary?
BufferedReader.readLine() returns null on EOF.
It seems plausable that only the readLine and writeString are needed in the loop.

Similarly, for the read loops below for InputStreams and binary stream.
The BufferedReader and readline can be used for the binary streams by constructing with the ASCII Charset.

If this single character is \n, then direct replacing with readLine would change behavior of the method.

I see your point and this PR isn't the place to figure out why a single newline in the attributes Vector would be significant vs an empty string or no entry.

RogerRiggs · 2022-09-26T18:42:03Z

src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java

+        BufferedReader bufReader = new BufferedReader(x);
+        try {
+            int i;
+            while ((i = bufReader.read()) != -1) {


I see your point and this PR isn't the place to figure out why a single newline in the attributes Vector would be significant vs an empty string or no entry.

openjdk · 2022-09-26T18:43:32Z

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294361: Cleanup usages of StringBuffer in SQLOutputImpl

Reviewed-by: rriggs, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

aca4276: 8294379: Missing comma after copyright year
1f521a1: 8225012: sanity/client/SwingSet/src/ToolTipDemoTest.java fails on Windows
5ae6bc2: 8234262: Unmask SIGQUIT in a child process
968af74: 8293567: AbstractSplittableWithBrineGenerator: salt has digits that duplicate the marker
36b61c5: 8293872: Make runtime/Thread/ThreadCountLimit.java more robust
2be3158: 4797982: Setting negative size of JSplitPane divider leads to unexpected results.
050eebf: 8294245: Make Compile::print_inlining_stream stack allocated
91a23d7: 8294142: make test should report only on executed tests
169a5d4: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory
3675f4c: 8293252: Shenandoah: ThreadMXBean synchronizer tests crash with aggressive heuristics
... and 94 more: https://git.openjdk.org/jdk/compare/cfd44bb2cd4f2fdbfc15a7a76757a92c0a557439...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

LanceAndersen

The changes seem fine based on what your goal was.

turbanoff · 2022-09-27T13:16:00Z

/integrate

openjdk · 2022-09-27T13:17:18Z

Going to push as commit 3419363.
Since your change was applied there have been 115 commits pushed to the master branch:

1abf971: 8249627: Degrade Thread.suspend and Thread.resume
bc12e95: 8292969: Bad Thread Utilization in ForkJoinPool
dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
14c6ac4: 8293998: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
02ea338: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c
49a7347: 8294408: Problemlist runtime/handshake/HandshakeSuspendExitTest.java
aa48705: 8289422: Fix and re-enable vector conditional move
1ddc92f: 8294404: [BACKOUT] JDK-8294142: make test should report only executed tests
1e222bc: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image
43eff2b: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator
... and 105 more: https://git.openjdk.org/jdk/compare/cfd44bb2cd4f2fdbfc15a7a76757a92c0a557439...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-27T13:17:37Z

@turbanoff Pushed as commit 3419363.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[PATCH] Cleanup usages of StringBuffer in SQLOutputImpl

3f65632

openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 17, 2022

turbanoff changed the title ~~[PATCH] Cleanup usages of StringBuffer in SQLOutputImpl~~ 8294361: Cleanup usages of StringBuffer in SQLOutputImpl Sep 26, 2022

openjdk bot added the rfr Pull request is ready for review label Sep 26, 2022

RogerRiggs reviewed Sep 26, 2022

View reviewed changes

RogerRiggs approved these changes Sep 26, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2022

LanceAndersen approved these changes Sep 26, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 27, 2022

openjdk bot closed this Sep 27, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2022

turbanoff deleted the cleanup_usages_of_StringBuffer_in_SQLOutputImpl branch October 27, 2022 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8294361: Cleanup usages of StringBuffer in SQLOutputImpl #10320

8294361: Cleanup usages of StringBuffer in SQLOutputImpl #10320

Uh oh!

turbanoff commented Sep 17, 2022 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 17, 2022

Uh oh!

openjdk bot commented Sep 17, 2022

Uh oh!

mlbridge bot commented Sep 26, 2022

Uh oh!

RogerRiggs Sep 26, 2022 •

edited

Loading

Uh oh!

turbanoff Sep 26, 2022

Uh oh!

RogerRiggs Sep 26, 2022

Uh oh!

RogerRiggs Sep 26, 2022

Uh oh!

openjdk bot commented Sep 26, 2022 •

edited

Loading

Uh oh!

LanceAndersen left a comment

Uh oh!

turbanoff commented Sep 27, 2022

Uh oh!

openjdk bot commented Sep 27, 2022

Uh oh!

openjdk bot commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

8294361: Cleanup usages of StringBuffer in SQLOutputImpl #10320

8294361: Cleanup usages of StringBuffer in SQLOutputImpl #10320

Uh oh!

Conversation

turbanoff commented Sep 17, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 17, 2022

Uh oh!

openjdk bot commented Sep 17, 2022

Uh oh!

mlbridge bot commented Sep 26, 2022

Webrevs

Uh oh!

RogerRiggs Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

turbanoff Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

RogerRiggs Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

RogerRiggs Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LanceAndersen left a comment

Choose a reason for hiding this comment

Uh oh!

turbanoff commented Sep 27, 2022

Uh oh!

openjdk bot commented Sep 27, 2022

Uh oh!

openjdk bot commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

turbanoff commented Sep 17, 2022 •

edited by openjdk bot

Loading

RogerRiggs Sep 26, 2022 •

edited

Loading

openjdk bot commented Sep 26, 2022 •

edited

Loading