6788481: CellEditorListener.editingCanceled is never called

[prsadhuk]

When editing of a table cell is canceled, the function editingCanceled of the registered listener CellEditorListener is not called as actionPerformed on ESC key press was not notifying the "cancel" listeners.
Fix is to handle "Cancel" action in actionPerformed() by forwarding the Cancel message from CellEditor to the delegate so that it can call AbstractCellEditor.fireEditingCanceled() which notifies all listeners of cancel event.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6788481: CellEditorListener.editingCanceled is never called

Reviewers

• Phil Race (@prrace - Reviewer) ⚠️ Review applies to 02c8fc00
• Alexander Zvegintsev (@azvegint - Reviewer) ⚠️ Review applies to 02c8fc00
• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to 3efbfa7b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10964/head:pull/10964
$ git checkout pull/10964

Update a local copy of the PR:
$ git checkout pull/10964
$ git pull https://git.openjdk.org/jdk pull/10964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10964

View PR using the GUI difftool:
$ git pr show -t 10964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10964.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b9a4bfc8)
• 01: Full - Incremental (3efbfa7b)
• 00: Full (02c8fc00)

[prrace]

I assume you ran all JTable tests (at leas) not just this new test.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6788481: CellEditorListener.editingCanceled is never called

Reviewed-by: prr, azvegint, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 681 new commits pushed to the master branch:

• 692bedb: 8297106: Remove the -Xcheck:jni local reference capacity checking
• 05128c2: 8286185: The Java manpage can be more platform inclusive
• d450314: 8297276: Remove thread text from Subject.current
• cdf9ed0: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 105d9d7: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
• a80552e: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools
• a249a52: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19
• 405b188: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
• ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
• c05dc80: 8297660: x86: Redundant test+jump in C1 allocateArray
• ... and 671 more: https://git.openjdk.org/jdk/compare/7a194d31a3f2f78211f035f4591845bf2b465aec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

I assume you ran all JTable tests (at leas) not just this new test.

I normally run the full clientlibs CI job which was ok.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 4e8e853.
Since your change was applied there have been 681 commits pushed to the master branch:

• 692bedb: 8297106: Remove the -Xcheck:jni local reference capacity checking
• 05128c2: 8286185: The Java manpage can be more platform inclusive
• d450314: 8297276: Remove thread text from Subject.current
• cdf9ed0: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 105d9d7: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
• a80552e: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools
• a249a52: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19
• 405b188: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
• ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
• c05dc80: 8297660: x86: Redundant test+jump in C1 allocateArray
• ... and 671 more: https://git.openjdk.org/jdk/compare/7a194d31a3f2f78211f035f4591845bf2b465aec...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 4e8e853.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.