8296612: CertAttrSet is useless

[wangweij]

• All CertAttrSet child classes now implement DerEncoder
• DerEncoder::derEncode is renamed to DerEncoder::encode, and duplicate methods are removed
• s.s.x.Extension now implements DerEncoder, so its child classes no need to implement it
• X509CertImpl::encode(OutputStream out) removed, used nowhere

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296612: CertAttrSet is useless

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11048/head:pull/11048
$ git checkout pull/11048

Update a local copy of the PR:
$ git checkout pull/11048
$ git pull https://git.openjdk.org/jdk pull/11048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11048

View PR using the GUI difftool:
$ git pr show -t 11048

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11048.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following labels will be automatically applied to this pull request:

• compiler
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8ae5fcd0)
• 00: Full (889e728e)

[wangweij]

/label remove compiler

[openjdk]

@wangweij
The compiler label was successfully removed.

[seanjmullan]

Looks good. Issue should probably have noreg-cleanup label.

[seanjmullan]

Add @Override.

[wangweij]

Not this one. :-)

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296612: CertAttrSet is useless

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 6b456f7: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
• e1badb7: 8295871: G1: Use different explicit claim marks for CLDs
• 9ef7852: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly
• d6468be: 8293886: The abstract keyword can be removed in AESCipher
• 54c986e: 8296715: CLDR v42 update for tzdata 2022f
• 4a68210: 6972078: Can not select single directory with GTKLookAndFeel
• 4465361: 8295948: Support for Zicbop/prefetch instructions on RISC-V
• f2acdfd: 8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT
• bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
• e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
• ... and 19 more: https://git.openjdk.org/jdk/compare/671f84bd8625ea7e06fa8272ae629309df06e9ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit 27527b4.
Since your change was applied there have been 29 commits pushed to the master branch:

• 6b456f7: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
• e1badb7: 8295871: G1: Use different explicit claim marks for CLDs
• 9ef7852: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly
• d6468be: 8293886: The abstract keyword can be removed in AESCipher
• 54c986e: 8296715: CLDR v42 update for tzdata 2022f
• 4a68210: 6972078: Can not select single directory with GTKLookAndFeel
• 4465361: 8295948: Support for Zicbop/prefetch instructions on RISC-V
• f2acdfd: 8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT
• bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
• e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
• ... and 19 more: https://git.openjdk.org/jdk/compare/671f84bd8625ea7e06fa8272ae629309df06e9ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 27527b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.