7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms

[valeriepeng]

Anyone can help reviewing this trivial RFE? Mostly just making clarifications on exception messages as submitter requested. Enhanced existing test case to check on this particular scenario.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)
• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11306/head:pull/11306
$ git checkout pull/11306

Update a local copy of the PR:
$ git checkout pull/11306
$ git pull https://git.openjdk.org/jdk pull/11306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11306

View PR using the GUI difftool:
$ git pr show -t 11306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11306.diff

[bridgekeeper]

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@valeriepeng The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9491f372)

[XueleiFan]

It looks good to me.

[openjdk]

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms

Reviewed-by: xuelei, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 5b3d86f: 8297230: Update Marlin2D to 0.9.4.6
• f4b5065: 8297435: Remove unused CompactibleSpaceClosure
• bde0e35: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
• f26bd4e: 8297350: Update JMH devkit to 1.36
• 470f342: 8296904: Improve handling of macos xcode toolchain
• b4bd287: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails
• 412b436: 6201035: Document NPE for passing null insets to constructors and methods of several javax.swing.border.* classes
• faf48e6: 8296329: jar validator doesn't account for minor class file version
• 09f70da: 8296265: Use modern HTML in the JVMTI spec
• e661c5a: 8296323: JVMTI can_support_virtual_threads not available for agents loaded into running VM
• ... and 5 more: https://git.openjdk.org/jdk/compare/260e4dcbfd8bdccdf332c2b6a07990cd14f6bcfb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[valeriepeng]

Thanks for the review~

[valeriepeng]

/integrate

[openjdk]

Going to push as commit 6dc4d89.
Since your change was applied there have been 21 commits pushed to the master branch:

• 2afb4c3: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
• 8df3bc4: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
• 086763a: 8297154: Improve safepoint cleanup logging
• e6e57fe: 8297507: Update header after JDK-8297230
• bc59f2a: 8295984: Remove unexpected JShell feature
• 0d93ab9: 8297000: [jib] Add more friendly warning for proxy issues
• 5b3d86f: 8297230: Update Marlin2D to 0.9.4.6
• f4b5065: 8297435: Remove unused CompactibleSpaceClosure
• bde0e35: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
• f26bd4e: 8297350: Update JMH devkit to 1.36
• ... and 11 more: https://git.openjdk.org/jdk/compare/260e4dcbfd8bdccdf332c2b6a07990cd14f6bcfb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@valeriepeng Pushed as commit 6dc4d89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.