8291444: GHA builds/tests won't run manually if disabled from automatic running

[RealCLanger]

This is an attempt to fix the issue reported in JDK-8291444.

The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push event but not on e.g. workflow_dispatch.
Currently setting JDK_SUBMIT_FILTER would lead to setting every platform to 'false', even when manually triggering the GHA run via workflow_dispatch.

I furthermore propose to relax the check for unknown events. In OpenJDK we only use/define workflow_dispatch and push. Other events would hence not trigger the workflow anyway. However, downstream vendors (like us in SapMachine) might use other events such as pull_request and they would then need to patch this away. This kind of downstream issue was also reported by Amazon. If you agree, I would remove the commented lines 91-93. Otherwise I have to uncomment them.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291444: GHA builds/tests won't run manually if disabled from automatic running

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to 5369e338
• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 5369e338
• Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 5369e338

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11365/head:pull/11365
$ git checkout pull/11365

Update a local copy of the PR:
$ git checkout pull/11365
$ git pull https://git.openjdk.org/jdk pull/11365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11365

View PR using the GUI difftool:
$ git pr show -t 11365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11365.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[RealCLanger]

@magicus @dholmes-ora FYA

[mlbridge]

Webrevs

• 01: Full - Incremental (d796fedd)
• 00: Full (5369e338)

[mrserb]

This should be reviewed by the build team. But I can confirm this change solve the problem I mentioned here.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291444: GHA builds/tests won't run manually if disabled from automatic running

Reviewed-by: serb, erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

Ping. Anybody from build group up to take a look?

[magicus]

If you agree, I would remove the commented lines 91-93.

Yes, that sounds good. Please remove the commented lines.

(I could have sworn I had already replied this, but either I forgot to press the green button, or I did it on the mobile and had connectivity issues I did not realize)

[RealCLanger]

Thanks for the reviews. I removed the commented lines. Will integrate later today.

[RealCLanger]

GHA error seems unrelated (langtools).
/integrate

[openjdk]

Going to push as commit 5c0ff26.
Since your change was applied there have been 4 commits pushed to the master branch:

• 6d0fbb2: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
• 687fd71: 8297549: RISC-V: Add support for Vector API vector load const operation
• d50015a: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension
• 9bbcb54: 8297784: Optimize @stable field for Method.isCallerSensitive

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 5c0ff26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

This change does not appear to have the fixed the issue it was filed to fix. The GHA tests still do not run for me when I choose a manual run.