Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297852: Backout 8252584 for the time being #11433

Closed
wants to merge 1 commit into from

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Nov 30, 2022

Revert 8252584 temporarily (My mistake)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11433/head:pull/11433
$ git checkout pull/11433

Update a local copy of the PR:
$ git checkout pull/11433
$ git pull https://git.openjdk.org/jdk pull/11433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11433

View PR using the GUI difftool:
$ git pr show -t 11433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11433.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2022

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TheShermanTanker TheShermanTanker changed the title Emergency Revert of 8252584 Backout 8252584 for the time being Nov 30, 2022
@TheShermanTanker TheShermanTanker changed the title Backout 8252584 for the time being 8252584 Nov 30, 2022
@TheShermanTanker TheShermanTanker changed the title 8252584 8297852 Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@TheShermanTanker The following labels will be automatically applied to this pull request:

  • build
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org labels Nov 30, 2022
@openjdk openjdk bot changed the title 8297852 8297852: Backout 8252584 for the time being Nov 30, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2022

Webrevs

@TheShermanTanker
Copy link
Contributor Author

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@TheShermanTanker
The build label was successfully removed.

@kimbarrett
Copy link

I've asked @vnkozlov what he wants to do about the premature integration.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @vnkozlov says backout and do a new one (will need a new JBS issue).

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297852: Backout 8252584 for the time being

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 6bac332: 8297853: windows-x86 test build broken
  • 53dd214: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests
  • 1323e98: 8297170: misc JCK tests fail with "FATAL ERROR in native method: JDWP Can't disable vthread end events, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • c685569: 8297731: Remove redundant check in MutableBigInteger.divide
  • dcf431d: 8287400: Make BitMap range parameter names consistent
  • a1f4db5: 8297584: G1 parallel phase event for scan heap roots is sent too often
  • be4245e: 8294924: JvmtiExport::post_exception_throw() doesn't deal well with concurrent stack processing
  • be99e84: 8296875: Generational ZGC: Refactor loom code
  • 301cf52: 8297284: ResolutionErrorTable's key is wrong
  • a97e7d9: 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live"
  • ... and 2 more: https://git.openjdk.org/jdk/compare/3f8882b2ebeeb25fbfddc1be3a069181856c2e27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2022
@TheShermanTanker
Copy link
Contributor Author

Thanks Kim, I'm really sorry about the goof

@TheShermanTanker
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 56048f9.
Since your change was applied there have been 18 commits pushed to the master branch:

  • f49acd5: 8297697: RISC-V: Add support for SATP mode detection
  • 3b513a4: 8297802: display of @SPEC tags should mimic that of @see tags
  • 4485d4e: 8297728: Cache invocation type rather than invoker in NamedFunction
  • e9d501e: 8297519: Improve expressions and modernise code in PKCS
  • 1722f9c: 8290231: java/foreign/malloc/TestMixedMallocFree.java crashed in JDK19 ATR run
  • 1a2ff58: 8297736: test/jdk/java/foreign/TestMatrix.java is broken
  • 6bac332: 8297853: windows-x86 test build broken
  • 53dd214: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests
  • 1323e98: 8297170: misc JCK tests fail with "FATAL ERROR in native method: JDWP Can't disable vthread end events, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • c685569: 8297731: Remove redundant check in MutableBigInteger.divide
  • ... and 8 more: https://git.openjdk.org/jdk/compare/3f8882b2ebeeb25fbfddc1be3a069181856c2e27...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@TheShermanTanker Pushed as commit 56048f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the revert branch December 1, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants