8299146: No copyright statement on ArtifactResolverException.java#11743
8299146: No copyright statement on ArtifactResolverException.java#11743XueleiFan wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into |
|
@XueleiFan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label add build |
|
@XueleiFan |
Webrevs
|
|
@XueleiFan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit f56285c.
Your commit was automatically rebased without conflicts. |
|
@XueleiFan Pushed as commit f56285c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The copyright statement was missed in the test file, test/lib/jdk/test/lib/artifacts/ArtifactResolverException.java. The file was added in JDK 11 by @erikj79 at 2018. This update is trying to add the copyright back.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11743/head:pull/11743$ git checkout pull/11743Update a local copy of the PR:
$ git checkout pull/11743$ git pull https://git.openjdk.org/jdk pull/11743/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11743View PR using the GUI difftool:
$ git pr show -t 11743Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11743.diff