Skip to content

8299146: No copyright statement on ArtifactResolverException.java#11743

Closed
XueleiFan wants to merge 2 commits intoopenjdk:masterfrom
XueleiFan:JDK-8299146
Closed

8299146: No copyright statement on ArtifactResolverException.java#11743
XueleiFan wants to merge 2 commits intoopenjdk:masterfrom
XueleiFan:JDK-8299146

Conversation

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Dec 20, 2022

The copyright statement was missed in the test file, test/lib/jdk/test/lib/artifacts/ArtifactResolverException.java. The file was added in JDK 11 by @erikj79 at 2018. This update is trying to add the copyright back.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299146: No copyright statement on ArtifactResolverException.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11743/head:pull/11743
$ git checkout pull/11743

Update a local copy of the PR:
$ git checkout pull/11743
$ git pull https://git.openjdk.org/jdk pull/11743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11743

View PR using the GUI difftool:
$ git pr show -t 11743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11743.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@XueleiFan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@XueleiFan
Copy link
Member Author

/label add build

@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@XueleiFan
The build label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299146: No copyright statement on ArtifactResolverException.java

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 386db07: Merge
  • f4d7f43: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus
  • 03afec1: 8298162: Test PrintClasses hits assert when run with code that retransform classes
  • 03d9927: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"
  • 65fc058: 8298968: G1: Incorrect merged remset stats
  • 8dfb6d7: 8298651: Serial: Remove MarkSweep::follow_klass

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2022
@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

Going to push as commit f56285c.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 396a9bf: 8298913: Add override qualifiers to Relocation classes
  • 386db07: Merge
  • f4d7f43: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus
  • 03afec1: 8298162: Test PrintClasses hits assert when run with code that retransform classes
  • 03d9927: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"
  • 65fc058: 8298968: G1: Incorrect merged remset stats
  • 8dfb6d7: 8298651: Serial: Remove MarkSweep::follow_klass

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2022
@openjdk openjdk bot closed this Dec 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@XueleiFan Pushed as commit f56285c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8299146 branch December 21, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants