8038146: Clarify Map.Entry's connection to the underlying map#11956
8038146: Clarify Map.Entry's connection to the underlying map#11956stuart-marks wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back smarks! A progress list of the required criteria for merging this PR into |
|
@stuart-marks The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
/csr |
|
@stuart-marks has indicated that a compatibility and specification (CSR) request is needed for this pull request. @stuart-marks please create a CSR request for issue JDK-8038146 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
Please review CSR JDK-8300622. |
|
@stuart-marks This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 278 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit c6d5600.
Your commit was automatically rebased without conflicts. |
|
@stuart-marks Pushed as commit c6d5600. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Also additional verbiage regarding Map.Entry objects in general and their possible connection to an underlying Map.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11956/head:pull/11956$ git checkout pull/11956Update a local copy of the PR:
$ git checkout pull/11956$ git pull https://git.openjdk.org/jdk pull/11956/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11956View PR using the GUI difftool:
$ git pr show -t 11956Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11956.diff