Skip to content

8038146: Clarify Map.Entry's connection to the underlying map#11956

Closed
stuart-marks wants to merge 2 commits intoopenjdk:masterfrom
stuart-marks:JDK-8038146-NavMap-Entry-setValue
Closed

8038146: Clarify Map.Entry's connection to the underlying map#11956
stuart-marks wants to merge 2 commits intoopenjdk:masterfrom
stuart-marks:JDK-8038146-NavMap-Entry-setValue

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jan 12, 2023

Also additional verbiage regarding Map.Entry objects in general and their possible connection to an underlying Map.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8300622 to be approved

Issues

  • JDK-8038146: Clarify Map.Entry's connection to the underlying map
  • JDK-8300622: Clarify Map.Entry's connection to the underlying map (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11956/head:pull/11956
$ git checkout pull/11956

Update a local copy of the PR:
$ git checkout pull/11956
$ git pull https://git.openjdk.org/jdk pull/11956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11956

View PR using the GUI difftool:
$ git pr show -t 11956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11956.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

@stuart-marks
Copy link
Member Author

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@stuart-marks has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@stuart-marks please create a CSR request for issue JDK-8038146 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@stuart-marks stuart-marks changed the title 8038146: Clarify NavigableMap/TreeMap support for Entry.setValue 8038146: Clarify Map.Entry's connection to the underlying map Jan 19, 2023
@stuart-marks
Copy link
Member Author

Please review CSR JDK-8300622.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jan 20, 2023
@openjdk
Copy link

openjdk bot commented Jan 20, 2023

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8038146: Clarify Map.Entry's connection to the underlying map

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 278 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 20, 2023
@stuart-marks
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 20, 2023

Going to push as commit c6d5600.
Since your change was applied there have been 286 commits pushed to the master branch:

  • b2d3622: 8299896: Reduce enum values of HtmlLinkInfo.Kind
  • 623ba5b: 8300653: G1EvacInfo should use common naming scheme for collection set
  • 97c611d: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
  • 4562b40: 8300682: InstanceKlassMiscStatus is a bad name
  • 26410c1: 8281213: Unsafe uses of long and size_t in MemReporterBase::diff_in_current_scale
  • eca6479: 8300087: Replace NULL with nullptr in share/cds/
  • 49d60fe: 8300172: java/net/httpclient/MappingResponseSubscriber.java failed with java.net.ConnectException
  • e189397: 8296403: [TESTBUG] IR test runner methods in TestLongRangeChecks.java invoke wrong test methods
  • 77f2d20: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions
  • 93a933d: 8300400: Update --release 20 symbol information for JDK 20 build 32
  • ... and 276 more: https://git.openjdk.org/jdk/compare/82deb5ca615f70634f8cd84836265d01edd1c5a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2023
@openjdk openjdk bot closed this Jan 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2023
@openjdk
Copy link

openjdk bot commented Jan 20, 2023

@stuart-marks Pushed as commit c6d5600.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants