8146132: Excessive output from make test-image

[erikj79]

Here is my attempt at solving Coleen's logging issue. This patch changes the log level for the "build info" log messages for all native test libs and executables to LogInfo. It also adds a new meta log message for each call to SetupTestFilesCompilation, which is kept on LogWarn level, which prints a single line with the number of test files being compiled in this call. For make test-image, we have 5 such calls so the output will look like this, which I think is quite reasonable:

Creating 1 test executable file(s) for BUILD_LIBTEST_JTREG_EXECUTABLES
Creating 45 test library file(s) for BUILD_JDK_JTREG_LIBRARIES
Creating 6 test executable file(s) for BUILD_JDK_JTREG_EXECUTABLES
Creating 853 test library file(s) for BUILD_HOTSPOT_JTREG_LIBRARIES
Creating 16 test executable file(s) for BUILD_HOTSPOT_JTREG_EXECUTABLES

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8146132: Excessive output from make test-image

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to f388ecc9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12052/head:pull/12052
$ git checkout pull/12052

Update a local copy of the PR:
$ git checkout pull/12052
$ git pull https://git.openjdk.org/jdk pull/12052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12052

View PR using the GUI difftool:
$ git pr show -t 12052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12052.diff

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erikj79 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (513d5368)
• 00: Full (f388ecc9)

[magicus]

Other than that, it looks good. Thank you for fixing this!

[magicus]

Suggested change

	$$(eval $$(BUILD_TEST_$$(name)_BUILD_INFO) :| $$($1_BUILD_INFO)) \
	$$(eval $$(BUILD_TEST_$$(name)_BUILD_INFO): | $$($1_BUILD_INFO)) \

The formatting threw me off here, wondering what kind of operator :| were. We usually have no space between target name and :, and a space before | for order-only, so I recommend to keep that style here.

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8146132: Excessive output from make test-image

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

• dcf1523: 8300077: Refactor code examples to use @snippet in java.text.ChoiceFormat
• d117350: 8300866: Declare some classes final in java.io
• 1a3cb8c: 8296343: CPVE thrown on missing content-length in OCSP response
• 86fed79: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
• 4525aa3: 8300867: Fix document issues in java.io
• a7f035d: 8300868: Reduce visibility in java.io.SerialCallbackContext
• 079255e: 8300864: Declare some fields in java.io as final
• a56598f: 8299684: (bf) JNI direct buffer functions with large capacity behave unexpectedly
• 542bfe6: 8300587: (bf) Some covariant overrides are missing @SInCE tags
• 03a9a88: 8300265: Remove metaprogramming/isSigned.hpp
• ... and 108 more: https://git.openjdk.org/jdk/compare/d7c05d18700e512722aee078c049389733f87867...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

Going to push as commit 0ea2dd1.
Since your change was applied there have been 118 commits pushed to the master branch:

• dcf1523: 8300077: Refactor code examples to use @snippet in java.text.ChoiceFormat
• d117350: 8300866: Declare some classes final in java.io
• 1a3cb8c: 8296343: CPVE thrown on missing content-length in OCSP response
• 86fed79: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests
• 4525aa3: 8300867: Fix document issues in java.io
• a7f035d: 8300868: Reduce visibility in java.io.SerialCallbackContext
• 079255e: 8300864: Declare some fields in java.io as final
• a56598f: 8299684: (bf) JNI direct buffer functions with large capacity behave unexpectedly
• 542bfe6: 8300587: (bf) Some covariant overrides are missing @SInCE tags
• 03a9a88: 8300265: Remove metaprogramming/isSigned.hpp
• ... and 108 more: https://git.openjdk.org/jdk/compare/d7c05d18700e512722aee078c049389733f87867...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 Pushed as commit 0ea2dd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.