6817009: Action.SELECTED_KEY not toggled when using key binding

[prsadhuk]

When the Action.SELECTED_KEY property action is assigned to ToggleButton and an accelerator key binding is mapped to the action, then pressing the accelerator key binding does not toggle the toggle button.
This is because SwingUtilities.notifyAction does not fire itemStateChanged event for such action related to SELECTED_KEY.
Fix is to get the Action.SELECTED_KEY command/action and fire itemStateChanged Event via JToggleButton.setSelected() call to notify propertyChange listener of the toggled property.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6817009: Action.SELECTED_KEY not toggled when using key binding

Reviewers

• Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to 4219c5c7
• Jayathirth D V (@jayathirthrao - Reviewer) ⚠️ Review applies to 4219c5c7

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12253/head:pull/12253
$ git checkout pull/12253

Update a local copy of the PR:
$ git checkout pull/12253
$ git pull https://git.openjdk.org/jdk.git pull/12253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12253

View PR using the GUI difftool:
$ git pr show -t 12253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12253.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (875d85e5)
• 00: Full (4219c5c7)

[TejeshR13]

Fix work as expected.

[bridgekeeper]

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jayathirthrao]

Apart from jtreg test comment, other changes looks good.
Verified regression test also.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6817009: Action.SELECTED_KEY not toggled when using key binding

Reviewed-by: tr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1189 new commits pushed to the master branch:

• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• 91f407d: 8029301: Confusing error message for array creation method reference
• e73411a: 8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE
• a2d8f63: 8288730: Add type parameter to Lookup::accessClass and Lookup::ensureInitialized
• 3777455: 8302191: Performance degradation for float/double modulo on Linux
• 760c012: 8304683: Memory leak in WB_IsMethodCompatible
• 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
• 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
• ddf1e34: 8304089: Convert TraceDependencies to UL
• 358c61b: 8294972: Convert jdk.jlink internal plugins to use the Classfile API
• ... and 1179 more: https://git.openjdk.org/jdk/compare/ce6395a1356a3d1334aeffc70ac8e4f86dd81a4c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit e2cfcfb.
Since your change was applied there have been 1190 commits pushed to the master branch:

• af4d560: 8303951: Add asserts before record_method_not_compilable where possible
• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• 91f407d: 8029301: Confusing error message for array creation method reference
• e73411a: 8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE
• a2d8f63: 8288730: Add type parameter to Lookup::accessClass and Lookup::ensureInitialized
• 3777455: 8302191: Performance degradation for float/double modulo on Linux
• 760c012: 8304683: Memory leak in WB_IsMethodCompatible
• 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
• 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
• ddf1e34: 8304089: Convert TraceDependencies to UL
• ... and 1180 more: https://git.openjdk.org/jdk/compare/ce6395a1356a3d1334aeffc70ac8e4f86dd81a4c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit e2cfcfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.