8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah

[earthling-amzn]

Allow Shenandoah barrier to emit the store barrier for native memory. I believe it is safe to delete the assert on L202 because obj is not used here. Tested with hotspot:hotspot_gc and hotspot:loom with JAVA_OPTIONS=-XX:+UseShenandoahGC (and again with -XX:TieredStopAtLevel=1).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah

Reviewers

• Roman Kennke (@rkennke - Reviewer)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12300/head:pull/12300
$ git checkout pull/12300

Update a local copy of the PR:
$ git checkout pull/12300
$ git pull https://git.openjdk.org/jdk pull/12300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12300

View PR using the GUI difftool:
$ git pr show -t 12300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12300.diff

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (83a178eb)

[rkennke]

It looks good to me, thank you!

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah

Reviewed-by: rkennke, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 145 new commits pushed to the master branch:

• d53ade1: 8301813: Bad caret position in error message
• 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
• c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
• b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
• 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
• ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 7ae447f: 8301095: [s390x] TestDwarf.java fails
• 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
• 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
• 7730506: 8299162: Refactor shared trampoline emission logic
• ... and 135 more: https://git.openjdk.org/jdk/compare/ae0e76d3dd42de9e66196843e740e75b06894f1f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version 83a178e) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 3ac2bed.
Since your change was applied there have been 145 commits pushed to the master branch:

• d53ade1: 8301813: Bad caret position in error message
• 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
• c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
• b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
• 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
• ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 7ae447f: 8301095: [s390x] TestDwarf.java fails
• 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
• 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
• 7730506: 8299162: Refactor shared trampoline emission logic
• ... and 135 more: https://git.openjdk.org/jdk/compare/ae0e76d3dd42de9e66196843e740e75b06894f1f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @earthling-amzn Pushed as commit 3ac2bed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.