Skip to content

8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah #12300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earthling-amzn wants to merge 2 commits into from
Closed

8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah #12300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
674fcc2
8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
earthling-amzn Jan 27, 2023
83a178e
Merge jdk:master into native-store-barrier
earthling-amzn Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ void ShenandoahBarrierSetC2::satb_write_barrier_pre(GraphKit* kit,

if (do_load) {
// We need to generate the load of the previous value
assert(obj != NULL, "must have a base");
assert(adr != NULL, "where are loading from?");
assert(pre_val == NULL, "loaded already?");
assert(val_type != NULL, "need a type");
Expand Down Expand Up @@ -499,10 +498,7 @@ Node* ShenandoahBarrierSetC2::store_at_resolved(C2Access& access, C2AccessValue&
const TypePtr* adr_type = access.addr().type();
Node* adr = access.addr().node();

bool anonymous = (decorators & ON_UNKNOWN_OOP_REF) != 0;
bool on_heap = (decorators & IN_HEAP) != 0;

if (!access.is_oop() || (!on_heap && !anonymous)) {
if (!access.is_oop()) {
return BarrierSetC2::store_at_resolved(access, val);
}

Expand Down