8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext

[mpdonova]

Implemented tests for the DomCryptoContext.iterator() method.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext

Reviewers

• Rajan Halade (@rhalade - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13445/head:pull/13445
$ git checkout pull/13445

Update a local copy of the PR:
$ git checkout pull/13445
$ git pull https://git.openjdk.org/jdk.git pull/13445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13445

View PR using the GUI difftool:
$ git pr show -t 13445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13445.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mpdonova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mpdonova The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (019ada0c)

[rhalade]

LGTM. @seanjmullan let us know if you have any comments?

[openjdk]

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext

Reviewed-by: rhalade, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• b60604e: 8305794: Unused interface sun.security.util.PermissionFactory can be removed
• 92521b1: 8305875: Test TraceVirtualThreadLocals should be run with continuations only
• 00eb348: 8305937: com/sun/jdi/SetLocalWhileThreadInNative.java fails with -XX:+TieredCompilation
• 1385c3d: 8305966: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64
• 90b4006: 8305847: Improve diagnosability and resilience of HttpClient::close tests
• d7dc474: 8305712: [MacOS] Deprecated Cocoa-NSEvent names
• e0620b8: 8296420: javac has long lines in its command-line help
• 6b9b7d1: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
• 2060c8e: 8305688: jdk build --with-memory-size=1024 broken by JDK-8305100
• 646b666: 8305900: Use loopback IP addresses in security policy files of httpclient tests
• ... and 9 more: https://git.openjdk.org/jdk/compare/d8af7a6014055295355a1242db6c2872299c6398...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade, @seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[seanjmullan]

LGTM. @seanjmullan let us know if you have any comments?

LGTM.

[mpdonova]

/integrate

[openjdk]

@mpdonova
Your change (at version 019ada0) is now ready to be sponsored by a Committer.

[rhalade]

/sponsor

[openjdk]

Going to push as commit 76cda9f.
Since your change was applied there have been 19 commits pushed to the master branch:

• b60604e: 8305794: Unused interface sun.security.util.PermissionFactory can be removed
• 92521b1: 8305875: Test TraceVirtualThreadLocals should be run with continuations only
• 00eb348: 8305937: com/sun/jdi/SetLocalWhileThreadInNative.java fails with -XX:+TieredCompilation
• 1385c3d: 8305966: ProblemList com/sun/jdi/JdbLastErrorTest.java on windows-x64
• 90b4006: 8305847: Improve diagnosability and resilience of HttpClient::close tests
• d7dc474: 8305712: [MacOS] Deprecated Cocoa-NSEvent names
• e0620b8: 8296420: javac has long lines in its command-line help
• 6b9b7d1: 8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0
• 2060c8e: 8305688: jdk build --with-memory-size=1024 broken by JDK-8305100
• 646b666: 8305900: Use loopback IP addresses in security policy files of httpclient tests
• ... and 9 more: https://git.openjdk.org/jdk/compare/d8af7a6014055295355a1242db6c2872299c6398...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade @mpdonova Pushed as commit 76cda9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.