Skip to content

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Apr 25, 2023

Four tests are cleaned and optimized, ready to open source.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306718: Optimize and opensource some old AWT tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13637/head:pull/13637
$ git checkout pull/13637

Update a local copy of the PR:
$ git checkout pull/13637
$ git pull https://git.openjdk.org/jdk.git pull/13637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13637

View PR using the GUI difftool:
$ git pr show -t 13637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13637.diff

Webrev

Link to Webrev Comment

Four tests are cleaned and optimized, ready to open source.
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306718: Optimize and opensource some old AWT tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 114 new commits pushed to the master branch:

  • c92883a: 8306772: Remove sun.security.x509.CertException, sun.security.x509.CertParseError
  • 0ff3a27: 8306008: Several Vector API tests fail for client VM after JDK-8304450
  • e8f62de: 8304676: [vectorapi] x86_32: Crash in Assembler::kmovql(Address, KRegister)
  • 98e8616: 8301169: java/net/httpclient/ThrowingSubscribersAsInputStream.java,ThrowingSubscribersAsInputStreamAsync.java, and other httpclient tests failing on windows: Unable to establish loopback connection
  • 07ea445: 8306838: GetGraphicsTest needs to be headful
  • 17ce097: 8266571: Sequenced Collections
  • bad6aa6: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
  • 5f50e99: 8306770: (fs) Remove obsolete os.version check from sun.nio.fs.BsdFileStore.supportsFileAttributeView
  • 9d1fe65: 8306740: G1: Change G1CardSetHashTableScan to lambda
  • a4a5385: 8306733: Remove template parameter of G1DetermineCompactionQueueClosure::free_pinned_region
  • ... and 104 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2023
@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

Going to push as commit 9beae21.
Since your change was applied there have been 117 commits pushed to the master branch:

  • 36d61c3: 8306765: Some client related jtreg problem list entries are malformed
  • 5f4965d: 8306687: Relax memory ordering constraints on metaspace atomic counters
  • 33d6614: 8304845: Update PCSC-Lite for Suse Linux to 1.9.9 and fix incomplete license wording
  • c92883a: 8306772: Remove sun.security.x509.CertException, sun.security.x509.CertParseError
  • 0ff3a27: 8306008: Several Vector API tests fail for client VM after JDK-8304450
  • e8f62de: 8304676: [vectorapi] x86_32: Crash in Assembler::kmovql(Address, KRegister)
  • 98e8616: 8301169: java/net/httpclient/ThrowingSubscribersAsInputStream.java,ThrowingSubscribersAsInputStreamAsync.java, and other httpclient tests failing on windows: Unable to establish loopback connection
  • 07ea445: 8306838: GetGraphicsTest needs to be headful
  • 17ce097: 8266571: Sequenced Collections
  • bad6aa6: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
  • ... and 107 more: https://git.openjdk.org/jdk/compare/e3ece365ce7dc92dd9d0a7ad9eb53ed9ea87f48d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2023
@openjdk openjdk bot closed this Apr 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@azuev-java Pushed as commit 9beae21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants