8306965: osThread allocation failures should not abort the VM

[dholmes-ora]

Trivial fix ... Currently OSThread allocation will abort the VM if there is not enough memory. While the fact we are exhausting C-heap means we are likely to abort for one reason or another, it isn't the role of thread starting to act as that trigger. So new OSThread() becomes new (std::nothrow) OSThread() and the existing null checks actually serve a purpose.

Change was suggested by Kim Barrett - thanks.

Testing:

• tiers 1-3 sanity
• GHA sanity

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306965: osThread allocation failures should not abort the VM

Reviewers

• Lois Foltan (@lfoltan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13879/head:pull/13879
$ git checkout pull/13879

Update a local copy of the PR:
$ git checkout pull/13879
$ git pull https://git.openjdk.org/jdk.git pull/13879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13879

View PR using the GUI difftool:
$ git pr show -t 13879

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13879.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0bbfd211)

[lfoltan]

Looks good and trivial.

• Lois

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306965: osThread allocation failures should not abort the VM

Reviewed-by: lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 4795c39: 8281103: Give example for Locale that is English and follows the ISO standards
• 958d4a7: 8307563: make most fields final in JavacTrees
• f250ab2: 8307377: Remove use of tagName from TagletWriterImpl.linkSeeReferenceOutput
• cc9f7ad: 8307765: DynamicArchiveHeader contents are missing in CDS mapfile
• edc4adb: 8307860: [BACKOUT] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• df90df2: 8307857: validate-source fails after JDK-8306758
• 2688364: 8306758: com/sun/jdi/ConnectedVMs.java fails with "Non-zero debuggee exitValue: 143"
• 1964954: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• 9af1787: 8307244: Remove redundant class RMIIIOPServerImpl
• 8a95020: 8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches
• ... and 33 more: https://git.openjdk.org/jdk/compare/d9052b946682d1c0f2629455d73fe4e6b95b29db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks @lfoltan !

/integrate

[openjdk]

Going to push as commit 3cb606e.
Since your change was applied there have been 43 commits pushed to the master branch:

• 4795c39: 8281103: Give example for Locale that is English and follows the ISO standards
• 958d4a7: 8307563: make most fields final in JavacTrees
• f250ab2: 8307377: Remove use of tagName from TagletWriterImpl.linkSeeReferenceOutput
• cc9f7ad: 8307765: DynamicArchiveHeader contents are missing in CDS mapfile
• edc4adb: 8307860: [BACKOUT] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• df90df2: 8307857: validate-source fails after JDK-8306758
• 2688364: 8306758: com/sun/jdi/ConnectedVMs.java fails with "Non-zero debuggee exitValue: 143"
• 1964954: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries
• 9af1787: 8307244: Remove redundant class RMIIIOPServerImpl
• 8a95020: 8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches
• ... and 33 more: https://git.openjdk.org/jdk/compare/d9052b946682d1c0f2629455d73fe4e6b95b29db...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit 3cb606e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.