Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed. #14036

Closed
wants to merge 3 commits into from

Conversation

TOatGithub
Copy link
Contributor

@TOatGithub TOatGithub commented May 17, 2023

From JDK-8307907:
The support of Transactional Memory has been removed in the Power 10 processor.
The removed instructions are still recognized, but all locking fails. This makes some jtreg tests fail.
Remove implementation from ppc port.
Disable corresponding jtreg tests.
Remove entries refering to ppc from ProblemLists.

Problem list tests on AIX which fail in Power9 Compatibility mode. See JBS for details.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14036/head:pull/14036
$ git checkout pull/14036

Update a local copy of the PR:
$ git checkout pull/14036
$ git pull https://git.openjdk.org/jdk.git pull/14036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14036

View PR using the GUI difftool:
$ git pr show -t 14036

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14036.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2023

👋 Welcome back TOatGithub! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2023
@openjdk
Copy link

openjdk bot commented May 17, 2023

@TOatGithub To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@TOatGithub
Copy link
Contributor Author

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@TOatGithub
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 22, 2023

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented May 22, 2023

@TOatGithub This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed.

Reviewed-by: clanger, goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • dc30e68: 8308407: libjvm library not reproducibly comparable between vendors
  • 18e2446: 8301381: Verify DTLS 1.0 cannot be negotiated
  • b3cb82b: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 3d550f7: 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland
  • 05e99db: 7065228: To interpret case-insensitive string locale independently
  • a970519: 8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms
  • 6b65e57: 8305785: Avoid redundant HashMap.containsKey call in java.util.regex
  • 8011ba7: 8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger, @GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 22, 2023
@GoeLin
Copy link
Member

GoeLin commented May 22, 2023

/label add hotspot-runtime

@openjdk
Copy link

openjdk bot commented May 22, 2023

@GoeLin The hotspot-runtime label was already applied.

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too.

@TOatGithub
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@TOatGithub
Your change (at version 34b2c66) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented May 22, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented May 22, 2023

Going to push as commit 4f88437.
Since your change was applied there have been 8 commits pushed to the master branch:

  • dc30e68: 8308407: libjvm library not reproducibly comparable between vendors
  • 18e2446: 8301381: Verify DTLS 1.0 cannot be negotiated
  • b3cb82b: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 3d550f7: 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland
  • 05e99db: 7065228: To interpret case-insensitive string locale independently
  • a970519: 8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms
  • 6b65e57: 8305785: Avoid redundant HashMap.containsKey call in java.util.regex
  • 8011ba7: 8308181: Generational ZGC: Remove CLDG_lock from old gen root scanning

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2023
@openjdk openjdk bot closed this May 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

@GoeLin @TOatGithub Pushed as commit 4f88437.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TOatGithub TOatGithub deleted the JDK-8307908 branch September 4, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants