-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8307908: [ppc] Add failing RTM tests to ProblemList until 8307907 is fixed. #14036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back TOatGithub! A progress list of the required criteria for merging this PR into |
@TOatGithub To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
change reference from sub 8307908 to main 8307907
/label add hotspot-runtime |
@TOatGithub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TOatGithub This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger, @GoeLin) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/label add hotspot-runtime |
@GoeLin The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too.
/integrate |
@TOatGithub |
/sponsor |
Going to push as commit 4f88437.
Your commit was automatically rebased without conflicts. |
@GoeLin @TOatGithub Pushed as commit 4f88437. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
From JDK-8307907:
The support of Transactional Memory has been removed in the Power 10 processor.
The removed instructions are still recognized, but all locking fails. This makes some jtreg tests fail.
Remove implementation from ppc port.
Disable corresponding jtreg tests.
Remove entries refering to ppc from ProblemLists.
Problem list tests on AIX which fail in Power9 Compatibility mode. See JBS for details.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14036/head:pull/14036
$ git checkout pull/14036
Update a local copy of the PR:
$ git checkout pull/14036
$ git pull https://git.openjdk.org/jdk.git pull/14036/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14036
View PR using the GUI difftool:
$ git pr show -t 14036
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14036.diff
Webrev
Link to Webrev Comment