Skip to content

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 31, 2023

A couple of trivial ProblemListings:
JDK-8309230 ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64
JDK-8309231 ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64
  • JDK-8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14250/head:pull/14250
$ git checkout pull/14250

Update a local copy of the PR:
$ git checkout pull/14250
$ git pull https://git.openjdk.org/jdk.git pull/14250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14250

View PR using the GUI difftool:
$ git pr show -t 14250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14250.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler
/label add serviceability
/label add core-libs

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8309230
/issue JDK-8309231

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 31, 2023 16:42
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk openjdk bot changed the title Jdk 8309230 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64 May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java.

@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64
8309231: ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 31, 2023
@dcubed-ojdk
Copy link
Member Author

@jddarcy - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit 45473ef.
Since your change was applied there have been 67 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@dcubed-ojdk Pushed as commit 45473ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented May 31, 2023

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants