Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309306: G1: Move is_obj_dead from HeapRegion to G1CollectedHeap #14265

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 1, 2023

Simple refactoring around HeapRegion::is_obj_dead.

Test: hotspot_gc


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309306: G1: Move is_obj_dead from HeapRegion to G1CollectedHeap (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14265/head:pull/14265
$ git checkout pull/14265

Update a local copy of the PR:
$ git checkout pull/14265
$ git pull https://git.openjdk.org/jdk.git pull/14265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14265

View PR using the GUI difftool:
$ git pr show -t 14265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14265.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8309306 8309306: G1: Move is_obj_dead from HeapRegion to G1CollectedHeap Jun 1, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 1, 2023
@openjdk
Copy link

openjdk bot commented Jun 1, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309306: G1: Move is_obj_dead from HeapRegion to G1CollectedHeap

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 161 new commits pushed to the master branch:

  • 4bc6bbb: 8309814: [IR Framework] Dump socket output string in which IR encoding was not found
  • cf9e635: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop
  • 268ec61: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 4d47069: 4516654: Metalworks Demo: Window title not displayed fully in Low Vision Theme
  • 408cadb: 8309467: Pattern dominance should be adjusted
  • 6c3e621: 8308749: C2 failed: regular loops only (counted loop inside infinite loop)
  • f5cbe53: 8027711: Unify wildcarding syntax for CompileCommand and CompileOnly
  • 4d66d97: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX
  • 3981297: 8309703: AIX build fails after JDK-8280982
  • 16c3d53: 8308603: Removing do_pending_ref/enclosing_ref from MetaspaceClosure
  • ... and 151 more: https://git.openjdk.org/jdk/compare/6adc242cf33941f1cbaa1f9e920c8700fd59aefc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2023
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit!

inline static bool obj_in_parsable_area(const HeapWord* addr, HeapWord* pb);
inline static bool obj_in_unparsable_area(oop obj, HeapWord* pb);
// Determine if an address is in the parsable or the to-be-scrubbed area.
inline bool is_in_parsable_area(const void* const addr) const;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing to align method names seems new to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some in g1FullCollector.hpp. I think this alignment groups the identical part while highlights the diff.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 12, 2023

Going to push as commit fdaa2c4.
Since your change was applied there have been 161 commits pushed to the master branch:

  • 4bc6bbb: 8309814: [IR Framework] Dump socket output string in which IR encoding was not found
  • cf9e635: 8309462: [AIX] vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java crashing due to empty while loop
  • 268ec61: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 4d47069: 4516654: Metalworks Demo: Window title not displayed fully in Low Vision Theme
  • 408cadb: 8309467: Pattern dominance should be adjusted
  • 6c3e621: 8308749: C2 failed: regular loops only (counted loop inside infinite loop)
  • f5cbe53: 8027711: Unify wildcarding syntax for CompileCommand and CompileOnly
  • 4d66d97: 8309549: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java fails on AIX
  • 3981297: 8309703: AIX build fails after JDK-8280982
  • 16c3d53: 8308603: Removing do_pending_ref/enclosing_ref from MetaspaceClosure
  • ... and 151 more: https://git.openjdk.org/jdk/compare/6adc242cf33941f1cbaa1f9e920c8700fd59aefc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 12, 2023
@openjdk openjdk bot closed this Jun 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 12, 2023
@openjdk
Copy link

openjdk bot commented Jun 12, 2023

@albertnetymk Pushed as commit fdaa2c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-is-obj-dead branch June 12, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants