8304478: Initial nroff manpage generation for JDK 22#14462
8304478: Initial nroff manpage generation for JDK 22#14462dholmes-ora wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
|
@dholmes-ora The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Thanks @AlanBateman ! |
|
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
sspitsyn
left a comment
There was a problem hiding this comment.
The Serviceability changes look good.
Thanks,
Serguei
Just curious, since you have access to the secret closed sources, can you not backport these changes yourself? Instead of just deleting them and expecting someone else to rescue them from oblivion? To be clear, I'm not blaming you for this situation - the problem is that there exist "closed sources" at all (why??) - but that doesn't seem like a good excuse for deleting work without a clear path to ensuring it is preserved (and the simplest way to do that is to do it yourself). Obviously I'd do it myself if I could. Thanks. |
@archiecobbs we (Oracle) will take care of restoring this text so please don't be concerned about that. It will just be a temporary glitch. It should have been handled when the original PRs were done. It needs to be handled as a separate issue and PR though - whether that were to happen before or after this PR is somewhat immaterial. |
|
Thanks for the additional reviews @sspitsyn , @LanceAndersen and @mlchung ! |
OK thanks. Putting my trust in you :) |
|
I've filed https://bugs.openjdk.org/browse/JDK-8310067 for the javac manpage fixup. |
|
The javac changes have been restored so I am merging them into this PR - the only difference should be minor formatting changes. This has also now picked up the jshell changes from JDK-8308988. |
|
The javac update has also now pulled in JDK-8308456 |
|
/integrate |
|
Going to push as commit b2e86ae.
Your commit was automatically rebased without conflicts. |
|
@dholmes-ora Pushed as commit b2e86ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Updated the version to 22-ea and year to 2024.
The following unpublished changes will also be included in this update:
The following changes, to
javac.1, were never applied to the closed sources and are "lost" by this update. These changes will need to be re-applied directly in JDK 21 and JDK 22:Thanks.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14462/head:pull/14462$ git checkout pull/14462Update a local copy of the PR:
$ git checkout pull/14462$ git pull https://git.openjdk.org/jdk.git pull/14462/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14462View PR using the GUI difftool:
$ git pr show -t 14462Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14462.diff
Webrev
Link to Webrev Comment