Skip to content

8304478: Initial nroff manpage generation for JDK 22#14462

Closed
dholmes-ora wants to merge 2 commits intoopenjdk:masterfrom
dholmes-ora:8304478-manpages
Closed

8304478: Initial nroff manpage generation for JDK 22#14462
dholmes-ora wants to merge 2 commits intoopenjdk:masterfrom
dholmes-ora:8304478-manpages

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 14, 2023

Updated the version to 22-ea and year to 2024.

The following unpublished changes will also be included in this update:

The following changes, to javac.1, were never applied to the closed sources and are "lost" by this update. These changes will need to be re-applied directly in JDK 21 and JDK 22:

  • JDK-8296656: java.lang.NoClassDefFoundError exception on running fully legitimate code
  • JDK-8015831: Add lint check for calling overridable methods from a constructor

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304478: Initial nroff manpage generation for JDK 22 (Task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14462/head:pull/14462
$ git checkout pull/14462

Update a local copy of the PR:
$ git checkout pull/14462
$ git pull https://git.openjdk.org/jdk.git pull/14462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14462

View PR using the GUI difftool:
$ git pr show -t 14462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14462.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@dholmes-ora The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org net net-dev@openjdk.org compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Jun 14, 2023
@dholmes-ora dholmes-ora marked this pull request as ready for review June 14, 2023 05:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2023

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@dholmes-ora
Copy link
Member Author

Thanks @AlanBateman !

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304478: Initial nroff manpage generation for JDK 22

Reviewed-by: alanb, sspitsyn, mchung, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

  • 7b45c8f: 8241800: Disable IPV6_MULTICAST_ALL to prevent interference from all multicast groups
  • 137a5f7: 8310105: LoongArch64 builds are broken after JDK-8304913
  • 33c6ec9: 8310019: MIPS builds are broken after JDK-8304913
  • e08e94f: 8310266: JFR: Refactor after 'view' command
  • f8f8bfb: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines
  • 7d4b77a: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • b896e3e: 8310146: Removing unused PerfLongVariant::_sampled
  • d2a858e: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode()
  • 4229baf: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
  • 266f983: 8308855: ARM32: TestBooleanVector crashes after 8300257
  • ... and 56 more: https://git.openjdk.org/jdk/compare/ba837b4bfa2dea85653d8a8fccd0817a569b4378...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 14, 2023
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Serviceability changes look good.
Thanks,
Serguei

@archiecobbs
Copy link
Contributor

The following changes, to javac.1, were never applied to the closed sources and are "lost" by this update. These changes will need to be re-applied directly in JDK 21 and JDK 22

Just curious, since you have access to the secret closed sources, can you not backport these changes yourself? Instead of just deleting them and expecting someone else to rescue them from oblivion?

To be clear, I'm not blaming you for this situation - the problem is that there exist "closed sources" at all (why??) - but that doesn't seem like a good excuse for deleting work without a clear path to ensuring it is preserved (and the simplest way to do that is to do it yourself). Obviously I'd do it myself if I could.

Thanks.

@dholmes-ora
Copy link
Member Author

Just curious, since you have access to the secret closed sources, can you not backport these changes yourself? Instead of just deleting them and expecting someone else to rescue them from oblivion?

@archiecobbs we (Oracle) will take care of restoring this text so please don't be concerned about that. It will just be a temporary glitch. It should have been handled when the original PRs were done. It needs to be handled as a separate issue and PR though - whether that were to happen before or after this PR is somewhat immaterial.

@dholmes-ora
Copy link
Member Author

Thanks for the additional reviews @sspitsyn , @LanceAndersen and @mlchung !

@archiecobbs
Copy link
Contributor

Just curious, since you have access to the secret closed sources, can you not backport these changes yourself? Instead of just deleting them and expecting someone else to rescue them from oblivion?

@archiecobbs we (Oracle) will take care of restoring this text so please don't be concerned about that. It will just be a temporary glitch.

OK thanks. Putting my trust in you :)

@dholmes-ora
Copy link
Member Author

I've filed https://bugs.openjdk.org/browse/JDK-8310067 for the javac manpage fixup.

@dholmes-ora
Copy link
Member Author

The javac changes have been restored so I am merging them into this PR - the only difference should be minor formatting changes.

This has also now picked up the jshell changes from JDK-8308988.

@dholmes-ora
Copy link
Member Author

The javac update has also now pulled in JDK-8308456

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

Going to push as commit b2e86ae.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 7b45c8f: 8241800: Disable IPV6_MULTICAST_ALL to prevent interference from all multicast groups
  • 137a5f7: 8310105: LoongArch64 builds are broken after JDK-8304913
  • 33c6ec9: 8310019: MIPS builds are broken after JDK-8304913
  • e08e94f: 8310266: JFR: Refactor after 'view' command
  • f8f8bfb: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines
  • 7d4b77a: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • b896e3e: 8310146: Removing unused PerfLongVariant::_sampled
  • d2a858e: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode()
  • 4229baf: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
  • 266f983: 8308855: ARM32: TestBooleanVector crashes after 8300257
  • ... and 56 more: https://git.openjdk.org/jdk/compare/ba837b4bfa2dea85653d8a8fccd0817a569b4378...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 19, 2023
@openjdk openjdk bot closed this Jun 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@dholmes-ora Pushed as commit b2e86ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8304478-manpages branch June 19, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org kulla kulla-dev@openjdk.org net net-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

6 participants