Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Aug 4, 2023

RISC-V is now the official Debian architecture. This means that the official repository is slowly building up the package set, while the old debian-ports repo is slowly rotting. For futureproof-ness, we want to bootstrap from the official repo going forward.

Additional testing:

  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313701: GHA: RISC-V should use the official repository for bootstrap (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15149/head:pull/15149
$ git checkout pull/15149

Update a local copy of the PR:
$ git checkout pull/15149
$ git pull https://git.openjdk.org/jdk.git pull/15149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15149

View PR using the GUI difftool:
$ git pr show -t 15149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15149.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the right thing to do now.

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313701: GHA: RISC-V should use the official repository for bootstrap

Reviewed-by: clanger, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2023
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds great to me. Thanks.

@shipilev
Copy link
Member Author

shipilev commented Aug 7, 2023

(sighs) Looks like debian-ports are becoming even more broken as we speak. I am integrating this to unbreak GHA.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

Going to push as commit 538f955.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 226cdc6: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
  • a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2023
@openjdk openjdk bot closed this Aug 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2023
@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@shipilev Pushed as commit 538f955.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8313701-riscv-gha branch August 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants