Skip to content

8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java#15679

Closed
chhagedorn wants to merge 1 commit intoopenjdk:masterfrom
chhagedorn:JDK-8316094
Closed

8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java#15679
chhagedorn wants to merge 1 commit intoopenjdk:masterfrom
chhagedorn:JDK-8316094

Conversation

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Sep 12, 2023

In order to reduce the noise in the JDK 22 CI, I'm problemlisting:

compiler/rangechecks/TestRangeCheckHoistingScaledIV.java

which fails regularly in tier6 and 7.

Thanks,
Christian


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java (Sub-task - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15679/head:pull/15679
$ git checkout pull/15679

Update a local copy of the PR:
$ git checkout pull/15679
$ git pull https://git.openjdk.org/jdk.git pull/15679/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15679

View PR using the GUI difftool:
$ git pr show -t 15679

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15679.diff

Webrev

Link to Webrev Comment

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@chhagedorn
Copy link
Member Author

Thanks Tobias for your review!

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316094: Problemlist compiler/rangechecks/TestRangeCheckHoistingScaledIV.java

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f55e799: 8316038: Fix doc typos in java.io.Console and java.util.Scanner

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2023
@chhagedorn
Copy link
Member Author

/label add hotspot-compiler

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@chhagedorn To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@chhagedorn
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

@chhagedorn
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

Going to push as commit 3b422d0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f55e799: 8316038: Fix doc typos in java.io.Console and java.util.Scanner

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2023
@openjdk openjdk bot closed this Sep 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@chhagedorn Pushed as commit 3b422d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants