8315871: Opensource five more Swing regression tests by azuev-java · Pull Request #15702 · openjdk/jdk

azuev-java · 2023-09-13T08:48:25Z

Clean up and move to open source five tests.
javax/swing/AncestorNotifier/4817630/bug4817630.java
javax/swing/BoxLayout/4191948/bug4191948.java
javax/swing/ComponentInputMap/4248723/bug4248723.java
javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java
javax/swing/DefaultButtonModel/4097723/bug4097723.java

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8315871: Opensource five more Swing regression tests (Bug - P4)

Reviewers

Damon Nguyen (@DamonGuy - Committer) ⚠️ Review applies to d9d32378
Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15702/head:pull/15702
$ git checkout pull/15702

Update a local copy of the PR:
$ git checkout pull/15702
$ git pull https://git.openjdk.org/jdk.git pull/15702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15702

View PR using the GUI difftool:
$ git pr show -t 15702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15702.diff

Webrev

Link to Webrev Comment

Clean up and move to open source five tests. javax/swing/AncestorNotifier/4817630/bug4817630.java javax/swing/BoxLayout/4191948/bug4191948.java javax/swing/ComponentInputMap/4248723/bug4248723.java javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java javax/swing/DefaultButtonModel/4097723/bug4097723.java

bridgekeeper · 2023-09-13T08:49:26Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-09-13T08:51:23Z

@azuev-java The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-09-13T08:56:13Z

Webrevs

…53.java Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

DamonGuy

LGTM. Just move the frame dispose code blocks to EDT.

DamonGuy · 2023-09-14T21:44:53Z

+            if (frame != null) {
+                frame.setVisible(false);
+                frame.dispose();
+            }


Should this if statement be run on EDT?

In new version the entire method is being run on EDT.

DamonGuy · 2023-09-14T21:45:31Z

+            SwingUtilities.invokeAndWait(test::init);
+            test.start();
+        } finally {
+            test.destroy();


Either destroy() or the if statement in destroy() for disposing the frame should be on EDT

azuev-java · 2023-09-25T17:55:06Z

Fixed found problems.

openjdk · 2023-09-25T18:13:34Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315871: Opensource five more Swing regression tests

Reviewed-by: dnguyen, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 292 new commits pushed to the master branch:

b65f4f7: 8313403: Remove unused 'mask' field from JFormattedTextField
e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
afa4833: 8271268: Fix Javadoc links for Stream.mapMulti
9688ec2: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
0f77d25: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
311c746: 8316859: RISC-V: Disable detection of V through HWCAP
0f0c5b2: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
3d6e775: 8316669: ImmutableOopMapSet destructor not called
837783c: 8316670: Remove effectively unused nmethodBucket::_count
... and 282 more: https://git.openjdk.org/jdk/compare/cef9fff0675c85906e134e4c0a8d2036860cd4b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java · 2023-09-25T18:26:50Z

/integrate

openjdk · 2023-09-25T18:30:53Z

Going to push as commit be9cc73.
Since your change was applied there have been 292 commits pushed to the master branch:

b65f4f7: 8313403: Remove unused 'mask' field from JFormattedTextField
e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
afa4833: 8271268: Fix Javadoc links for Stream.mapMulti
9688ec2: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
0f77d25: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
311c746: 8316859: RISC-V: Disable detection of V through HWCAP
0f0c5b2: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
3d6e775: 8316669: ImmutableOopMapSet destructor not called
837783c: 8316670: Remove effectively unused nmethodBucket::_count
... and 282 more: https://git.openjdk.org/jdk/compare/cef9fff0675c85906e134e4c0a8d2036860cd4b3...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-09-25T18:31:00Z

@azuev-java Pushed as commit be9cc73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023

openjdk bot added the client client-libs-dev@openjdk.org label Sep 13, 2023

turbanoff reviewed Sep 13, 2023

View reviewed changes

Comment thread test/jdk/javax/swing/DefaultBoundedRangeModel/4297953/bug4297953.java

turbanoff reviewed Sep 13, 2023

View reviewed changes

Comment thread test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java

azuev-java and others added 2 commits September 14, 2023 08:22

Update test/jdk/javax/swing/DefaultBoundedRangeModel/4297953/bug42979…

ea00636

…53.java Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

Update test/jdk/javax/swing/AncestorNotifier/4817630/bug4817630.java

d9d3237

Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

DamonGuy approved these changes Sep 14, 2023

View reviewed changes

Small fixes based on the review feedback

6f2847d

prrace approved these changes Sep 25, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2023

openjdk bot added the integrated Pull request has been integrated label Sep 25, 2023

openjdk bot closed this Sep 25, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2023

Conversation

azuev-java commented Sep 13, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 13, 2023

Uh oh!

openjdk bot commented Sep 13, 2023

Uh oh!

mlbridge bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Uh oh!

DamonGuy left a comment

Choose a reason for hiding this comment

Uh oh!

DamonGuy Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

azuev-java Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

DamonGuy Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

azuev-java Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

azuev-java commented Sep 25, 2023

Uh oh!

openjdk bot commented Sep 25, 2023

Uh oh!

azuev-java commented Sep 25, 2023

Uh oh!

openjdk bot commented Sep 25, 2023

Uh oh!

openjdk bot commented Sep 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

azuev-java commented Sep 13, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 13, 2023 •

edited

Loading