Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316056: Open source several Swing JTree tests #15756

Closed

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Sep 14, 2023

These are the tests being converted:

javax/swing/JTree/4210432/bug4210432.java
javax/swing/JTree/4213868/bug4213868.java
javax/swing/JTree/4224491/bug4224491.java
javax/swing/JTree/4237370/bug4237370.java
javax/swing/JTree/4662505/bug4662505.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316056: Open source several Swing JTree tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15756/head:pull/15756
$ git checkout pull/15756

Update a local copy of the PR:
$ git checkout pull/15756
$ git pull https://git.openjdk.org/jdk.git pull/15756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15756

View PR using the GUI difftool:
$ git pr show -t 15756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15756.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good.

test/jdk/javax/swing/JTree/bug4213868.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTree/bug4213868.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTree/bug4213868.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTree/bug4213868.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTree/bug4224491.java Outdated Show resolved Hide resolved
test/jdk/javax/swing/JTree/bug4237370.java Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316056: Open source several Swing JTree tests

Reviewed-by: honkar, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 177 new commits pushed to the master branch:

  • 4421951: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • f09b7af: 8311220: Optimization for StringLatin UpperLower
  • 2e2d49c: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • bf9d1e2: 8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX
  • 21c2dac: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
  • ecce2af: 8316357: Serial: Remove unused GenCollectedHeap::space_containing
  • 3828dc9: 8314236: Overflow in Collections.rotate
  • 1203e11: 8294969: Convert jdk.jdeps javap to use the Classfile API
  • fbc766e: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm
  • aa0ebee: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • ... and 167 more: https://git.openjdk.org/jdk/compare/969fcdb0de962b6eda7b362af010cb138e45afcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2023
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

Going to push as commit 5f6cee8.
Since your change was applied there have been 201 commits pushed to the master branch:

  • b685ee0: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • e0f8d16: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags
  • 7b1e2bf: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases
  • da57d2a: 8308592: Framework for CA interoperability testing
  • a6d120d: 8316513: Serial: Remove unused invalidate_remembered_set
  • 607bd4e: 8316294: AIX: Build fopen system call fails on file _BUILD_LIBJDWP_objectfilenames.txt
  • f25c920: 8314774: Optimize URLEncoder
  • 7c5f2a2: 8315669: Open source several Swing PopupMenu related tests
  • cf74b8c: 8316337: (bf) Concurrency issue in DirectByteBuffer.Deallocator
  • 4461eeb: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked
  • ... and 191 more: https://git.openjdk.org/jdk/compare/969fcdb0de962b6eda7b362af010cb138e45afcf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2023
@openjdk openjdk bot closed this Sep 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@DamonGuy Pushed as commit 5f6cee8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants