8316428: G1: Nmethod count statistics only count last code root set iterated

[tschatzl]

Hi all,

please review this small fix to nmethod code root counting where currently only the last code root set scanned counts.

Testing: gha

Hth,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316428: G1: Nmethod count statistics only count last code root set iterated (Bug - P4)

Reviewers

• Ivan Walulya (@walulyai - Reviewer) ⚠️ Review applies to 846e310d
• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 846e310d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15790/head:pull/15790
$ git checkout pull/15790

Update a local copy of the PR:
$ git checkout pull/15790
$ git pull https://git.openjdk.org/jdk.git pull/15790/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15790

View PR using the GUI difftool:
$ git pr show -t 15790

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15790.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316428: G1: Nmethod count statistics only count last code root set iterated

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 2e2d49c: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
• bf9d1e2: 8316399: Exclude java/net/MulticastSocket/Promiscuous.java on AIX
• 21c2dac: 8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX
• ecce2af: 8316357: Serial: Remove unused GenCollectedHeap::space_containing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (22aee485)
• 00: Full (846e310d)

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews

/integrate

[openjdk]

Going to push as commit fab372d.
Since your change was applied there have been 18 commits pushed to the master branch:

• 283c360: 8314877: Make fields final in 'java.net' package
• 86115c2: 8316420: Serial: Remove unused GenCollectedHeap::oop_iterate
• d038571: 8030815: Code roots are not accounted for in region prediction
• 138542d: 8316061: Open source several Swing RootPane and Slider related tests
• f52e500: 8316104: Open source several Swing SplitPane and RadioButton related tests
• 3760a04: 8314021: HeapDump: Optimize segmented heap file merging phase
• f226ceb: 8316440: LambdasInTwoArchives.java failed to find WhiteBox.class
• 24c3d86: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
• 373e37b: 8313813: Field sun.util.calendar.CalendarDate#forceStandardTime is never set
• 5308bbb: 8246280: Refine API to model sealed classes and interfaces in javax.lang.model
• ... and 8 more: https://git.openjdk.org/jdk/compare/3828dc913a3ea28d622b69bd07f26949128eb5f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit fab372d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.