Skip to content

8317592: Serial: Remove Space::toContiguousSpace #16054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertnetymk wants to merge 1 commit into from
Closed

8317592: Serial: Remove Space::toContiguousSpace #16054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hotspot/share/gc/serial/cardTableRS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
class DirtyCardToOopClosure: public MemRegionClosure {
protected:
OopIterateClosure* _cl;
Space* _sp;
TenuredSpace* _sp;
HeapWord* _min_done; // Need a downwards traversal to compensate
// imprecise write barrier; this is the
// lowest location already done (or,
Expand Down Expand Up @@ -88,7 +88,7 @@ class DirtyCardToOopClosure: public MemRegionClosure {
HeapWord* bottom, HeapWord* top,
OopIterateClosure* cl);
public:
DirtyCardToOopClosure(Space* sp, OopIterateClosure* cl) :
DirtyCardToOopClosure(TenuredSpace* sp, OopIterateClosure* cl) :
_cl(cl), _sp(sp), _min_done(nullptr) {
NOT_PRODUCT(_last_bottom = nullptr);
}
Expand All @@ -98,7 +98,7 @@ class DirtyCardToOopClosure: public MemRegionClosure {

HeapWord* DirtyCardToOopClosure::get_actual_top(HeapWord* top,
HeapWord* top_obj) {
if (top_obj != nullptr && top_obj < (_sp->toContiguousSpace())->top()) {
if (top_obj != nullptr && top_obj < _sp->top()) {
if (cast_to_oop(top_obj)->is_objArray() || cast_to_oop(top_obj)->is_typeArray()) {
// An arrayOop is starting on the dirty card - since we do exact
// store checks for objArrays we are done.
Expand All @@ -111,7 +111,7 @@ HeapWord* DirtyCardToOopClosure::get_actual_top(HeapWord* top,
top = top_obj + cast_to_oop(top_obj)->size();
}
} else {
top = (_sp->toContiguousSpace())->top();
top = _sp->top();
}
return top;
}
Expand Down
11 changes: 0 additions & 11 deletions src/hotspot/share/gc/shared/space.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,6 @@ class Space: public CHeapObj<mtGC> {
virtual void print_short() const;
virtual void print_short_on(outputStream* st) const;


// IF "this" is a ContiguousSpace, return it, else return null.
virtual ContiguousSpace* toContiguousSpace() {
return nullptr;
}

// Debugging
virtual void verify() const = 0;
};
Expand Down Expand Up @@ -415,11 +409,6 @@ class ContiguousSpace: public Space {

void print_on(outputStream* st) const override;

// Checked dynamic downcasts.
ContiguousSpace* toContiguousSpace() override {
return this;
}

// Debugging
void verify() const override;
};
Expand Down