Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320410: Reflow markdown in building.md #16737

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 20, 2023

Reflow the markdown in building.md so line lengths of 80 is respected, wherever possible.

Note that is is correct that the building.html file is unchanged (and indeed a sign that only markdown line breaks have been modified).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320410: Reflow markdown in building.md (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16737/head:pull/16737
$ git checkout pull/16737

Update a local copy of the PR:
$ git checkout pull/16737
$ git pull https://git.openjdk.org/jdk.git pull/16737/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16737

View PR using the GUI difftool:
$ git pr show -t 16737

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16737.diff

Webrev

Link to Webrev Comment

@magicus
Copy link
Member Author

magicus commented Nov 20, 2023

/integrate auto

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review auto labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@magicus This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 20, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320410: Reflow markdown in building.md

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 7f23110: 8319928: Exceptions thrown by cleanup actions should be handled correctly
  • a6098e4: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

Going to push as commit 04fd17e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7f23110: 8319928: Exceptions thrown by cleanup actions should be handled correctly
  • a6098e4: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023
@openjdk openjdk bot closed this Nov 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@openjdk[bot] Pushed as commit 04fd17e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the readme-reflow branch November 20, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants