Skip to content

8320526: Use title case in building.md#16765

Closed
magicus wants to merge 1 commit intoopenjdk:masterfrom
magicus:readme-title-case
Closed

8320526: Use title case in building.md#16765
magicus wants to merge 1 commit intoopenjdk:masterfrom
magicus:readme-title-case

Conversation

@magicus
Copy link
Copy Markdown
Member

@magicus magicus commented Nov 21, 2023

We should use title case consistently in building.md.

I thought I was done with fixing up the build README, but then I noticed this and I couldn't unsee it...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320526: Use title case in building.md (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16765/head:pull/16765
$ git checkout pull/16765

Update a local copy of the PR:
$ git checkout pull/16765
$ git pull https://git.openjdk.org/jdk.git pull/16765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16765

View PR using the GUI difftool:
$ git pr show -t 16765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16765.diff

Webrev

Link to Webrev Comment

@magicus
Copy link
Copy Markdown
Member Author

magicus commented Nov 21, 2023

/integrate auto

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review auto Expect automatic integration when ready; no further action required labels Nov 21, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Nov 21, 2023

@magicus This pull request will be automatically integrated when it is ready

@openjdk
Copy link
Copy Markdown

openjdk bot commented Nov 21, 2023

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 21, 2023
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Nov 21, 2023

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk bot commented Nov 21, 2023

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320526: Use title case in building.md

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Nov 21, 2023

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Nov 21, 2023

Going to push as commit 9311749.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Nov 21, 2023

@openjdk[bot] Pushed as commit 9311749.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the readme-title-case branch November 21, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto Expect automatic integration when ready; no further action required build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants