8320805: JFR: Create view for deprecated methods

[egahlin]

Could I have a review of a new view for the 'jfr' command to display deprecated methods for removal.

Usage:

$ jfr view deprecated-methods-for-removal <recording-file>

If the package name doesn't fit, the --width size option can be specified.

A new aggregator function SET is introduced and if the cell-height is more than 1, items in the set, or list, are written on separate lines. I also added support for the synthetic field "stackTrace.topFrame.class". Long term plan is to allow ".class" suffix on any method/frame field, not just the topFrame. Elipsis is no longer used when contents exactly matches the column width. Switched to LinkedHashSet to make results deterministic and in the order items are found in the file.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320805: JFR: Create view for deprecated methods (Enhancement - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17000/head:pull/17000
$ git checkout pull/17000

Update a local copy of the PR:
$ git checkout pull/17000
$ git pull https://git.openjdk.org/jdk.git pull/17000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17000

View PR using the GUI difftool:
$ git pr show -t 17000

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17000.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (11f47fe8)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320805: JFR: Create view for deprecated methods

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

• 75a7c19: 8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors
• 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
• 50baaf4: 8321013: Parallel: Refactor ObjectStartArray
• afb8964: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS
• 82796bd: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
• 781775d: 8321484: Make TestImplicitlyDeclaredClasses release independent
• b02fc86: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
• 2830dd2: 8321410: Shenandoah: Remove ShenandoahSuspendibleWorkers flag
• f482260: 8319969: os::large_page_init() turns off THPs for ZGC
• 3edc24a: 8321073: Defer policy of disabling annotation processing by default
• ... and 100 more: https://git.openjdk.org/jdk/compare/da09eabdfc51599d0a34b07c538fba4009af57c5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit b5933b1.
Since your change was applied there have been 118 commits pushed to the master branch:

• 29d7a22: 8321270: Virtual Thread.yield consumes parking permit
• 0b0fa47: 8319925: CSS.BackgroundImage incorrectly uses double-checked locking
• 0048f1d: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
• 49fff01: 8211238: @deprecated JFR event
• 656b446: 8320969: Shenandoah: Enforce stable number of GC workers
• 9a87e52: 8320538: Obsolete CSS styles in collection framework doc-file
• 03c4595: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
• 632a3c5: 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04
• 75a7c19: 8315827: Kitchensink.java and RenaissanceStressTest.java time out with jvmti module errors
• 91ffdfb: 8320365: IPPPrintService.getAttributes() causes blanket re-initialisation
• ... and 108 more: https://git.openjdk.org/jdk/compare/da09eabdfc51599d0a34b07c538fba4009af57c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit b5933b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.