Skip to content

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jan 3, 2024

A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322963: ProblemList java/io/BufferedInputStream/TransferTo.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17249/head:pull/17249
$ git checkout pull/17249

Update a local copy of the PR:
$ git checkout pull/17249
$ git pull https://git.openjdk.org/jdk.git pull/17249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17249

View PR using the GUI difftool:
$ git pr show -t 17249

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17249.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review January 3, 2024 17:13
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322963: ProblemList java/io/BufferedInputStream/TransferTo.java

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@dcubed-ojdk
The core-libs label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@bplb - Thanks for the lightning fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

Going to push as commit cc9ab5f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2024
@openjdk openjdk bot closed this Jan 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@dcubed-ojdk Pushed as commit cc9ab5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8322963 branch January 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants